From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB9EC3A589 for ; Thu, 15 Aug 2019 15:18:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B8552084D for ; Thu, 15 Aug 2019 15:18:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565882328; bh=emtmpN8koXyGRnpKRd+goYJhZ3VVizKGLhWaG2eElpw=; h=In-Reply-To:References:Subject:From:Cc:To:Date:List-ID:From; b=hGQm7DnkSAFNK4jgYCMbzy0MXyAAqeW8VP6GssQOaT7J7l3QvmcNID0VHP1YnN/K1 6lEGhnwuwnFgMUdw1PJEkb1AQ217gOZqiGc80brUADMtBzTJZarGfBb0s6A8x96wel 3lOAcCJXuWUYBthfwyPkUwQtpVljk96ob5bPGiLs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfHOPSr (ORCPT ); Thu, 15 Aug 2019 11:18:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:56688 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfHOPSr (ORCPT ); Thu, 15 Aug 2019 11:18:47 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA999206C1; Thu, 15 Aug 2019 15:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565882327; bh=emtmpN8koXyGRnpKRd+goYJhZ3VVizKGLhWaG2eElpw=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CgTdZg7C4TKnbBcwJyBIKQohYSn3rP7ceSj4iWdoGWybsqCHWcLT6u2zkbpHNS+mY ni5KaAhohoeBCsJtfd6ldxVNfg9im9mNK9+B88A95VgPPp4NupMoQ4oVVL5gef2+Kl eV/3sQ1uQdH+8uoIYqY05sSrG8Hn7BAY9r5DYpqo= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190815080146.4tkudfzus7uryoe6@flea> References: <20190815041037.3470-1-sboyd@kernel.org> <20190815080146.4tkudfzus7uryoe6@flea> Subject: Re: [PATCH] clk: sunxi: Don't call clk_hw_get_name() on a hw that isn't registered From: Stephen Boyd Cc: Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Chen-Yu Tsai To: Maxime Ripard User-Agent: alot/0.8.1 Date: Thu, 15 Aug 2019 08:18:46 -0700 Message-Id: <20190815151846.DA999206C1@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Maxime Ripard (2019-08-15 01:01:46) > On Wed, Aug 14, 2019 at 09:10:37PM -0700, Stephen Boyd wrote: > > The implementation of clk_hw_get_name() relies on the clk_core > > associated with the clk_hw pointer existing. If of_clk_hw_register() > > fails, there isn't a clk_core created yet, so calling clk_hw_get_name() > > here fails. Extract the name first so we can print it later. > > > > Fixes: 1d80c14248d6 ("clk: sunxi-ng: Add common infrastructure") > > Cc: Maxime Ripard > > Cc: Chen-Yu Tsai > > Signed-off-by: Stephen Boyd >=20 > Acked-by: Maxime Ripard >=20 > Do you want to apply it yourself, or should I merge this and send you > a PR later? >=20 I can apply it myself. Thanks! Now to figure out the real problem...