From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD63C432C1 for ; Tue, 24 Sep 2019 12:00:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20DD72168B for ; Tue, 24 Sep 2019 12:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395395AbfIXMAV (ORCPT ); Tue, 24 Sep 2019 08:00:21 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:47041 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388614AbfIXMAV (ORCPT ); Tue, 24 Sep 2019 08:00:21 -0400 X-Originating-IP: 90.65.161.137 Received: from localhost (lfbn-1-1545-137.w90-65.abo.wanadoo.fr [90.65.161.137]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5909A20018; Tue, 24 Sep 2019 12:00:19 +0000 (UTC) Date: Tue, 24 Sep 2019 14:00:18 +0200 From: Alexandre Belloni To: Eugen.Hristev@microchip.com Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Nicolas.Ferre@microchip.com Subject: Re: [PATCH] clk: at91: sam9x60: fix programmable clock Message-ID: <20190924120018.GA4757@piout.net> References: <1569321191-27606-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1569321191-27606-1-git-send-email-eugen.hristev@microchip.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 24/09/2019 10:39:09+0000, Eugen.Hristev@microchip.com wrote: > From: Eugen Hristev > > The prescaler mask for sam9x60 must be 0xff (8 bits). > Being set to 0, means that we cannot set any prescaler, thus the > programmable clocks do not work (except the case with prescaler 0) > Set the mask accordingly in layout struct. > > Fixes: 01e2113de9a5 ("clk: at91: add sam9x60 pmc driver") > Signed-off-by: Eugen Hristev Acked-by: Alexandre Belloni > --- > drivers/clk/at91/sam9x60.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/at91/sam9x60.c b/drivers/clk/at91/sam9x60.c > index 9790ddf..86238d5 100644 > --- a/drivers/clk/at91/sam9x60.c > +++ b/drivers/clk/at91/sam9x60.c > @@ -43,6 +43,7 @@ static const struct clk_pll_characteristics upll_characteristics = { > }; > > static const struct clk_programmable_layout sam9x60_programmable_layout = { > + .pres_mask = 0xff, > .pres_shift = 8, > .css_mask = 0x1f, > .have_slck_mck = 0, > -- > 2.7.4 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com