From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
Wen He <wen.he_1@nxp.com>
Subject: Re: [PATCH 1/2] clk: ls1028a: Fix warning on clamp() usage
Date: Mon, 03 Feb 2020 10:33:52 -0800 [thread overview]
Message-ID: <20200203183353.833852082E@mail.kernel.org> (raw)
In-Reply-To: <20200203052507.93215-1-sboyd@kernel.org>
Quoting Stephen Boyd (2020-02-02 21:25:06)
> These constants are used in clamp() with the value being clamped an
> unsigned long. Make them unsigned long defines so that clamp() doesn't
> complain about comparing different types.
>
> In file included from include/linux/list.h:9,
> from include/linux/kobject.h:19,
> from include/linux/of.h:17,
> from include/linux/clk-provider.h:9,
> from drivers/clk/clk-plldig.c:8:
> drivers/clk/clk-plldig.c: In function 'plldig_determine_rate':
> include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
> 835 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> |
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: Wen He <wen.he_1@nxp.com>
> Fixes: d37010a3c162 ("clk: ls1028a: Add clock driver for Display output interface")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
Applied to clk-next
prev parent reply other threads:[~2020-02-03 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 5:25 [PATCH 1/2] clk: ls1028a: Fix warning on clamp() usage Stephen Boyd
2020-02-03 5:25 ` [PATCH 2/2] dt/bindings: clk: fsl,plldig: Drop 'bindings' from schema id Stephen Boyd
2020-02-03 9:39 ` Rob Herring
2020-02-03 18:33 ` Stephen Boyd
2020-02-03 18:33 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203183353.833852082E@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sfr@canb.auug.org.au \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).