From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05AF7C3524A for ; Tue, 4 Feb 2020 07:03:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCD072166E for ; Tue, 4 Feb 2020 07:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580799835; bh=HTGPXQ9wkE1o/Ti9Lpl2TuNVsDBpS1uSDCbHfoQO6mU=; h=In-Reply-To:References:From:To:Subject:Cc:Date:List-ID:From; b=TsdHs+VbLDXW6rXbku2tbNfA7h8eYmq5DjQJ9dSrtn6BcQQZQTUp2wlFpz2fZ3qaF q8f9lKn565PAOVxNj52CX99Irt+8xUXTJcTqshsqUbkteMUcd/sR4NNIqcAQdfuK8A Yi8R+YIDbuSTWnkmYHyAUsQJsrAw63Oae/nzzbQM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgBDHDz (ORCPT ); Tue, 4 Feb 2020 02:03:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:53414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgBDHDz (ORCPT ); Tue, 4 Feb 2020 02:03:55 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB16A20674; Tue, 4 Feb 2020 07:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580799834; bh=HTGPXQ9wkE1o/Ti9Lpl2TuNVsDBpS1uSDCbHfoQO6mU=; h=In-Reply-To:References:From:To:Subject:Cc:Date:From; b=vMna10M09ifWPqBEQierFOk+cxdm9C2IcbIPRLFEHI3DZIZxGRX1SoeGoN7+v9HJB UrD5pfwvmK176YbJUSQsegrXEwVoY0AZXbKFGQ5Rmssc46EI4O5/d+HaBcWAEConI7 zSyTjNkvPy+GtAfmTD16l/ZpkQhczlTy8zqHZOpg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200203223736.99645-1-colin.king@canonical.com> References: <20200203223736.99645-1-colin.king@canonical.com> From: Stephen Boyd To: Colin King , Michael Turquette , Michael Walle , Wen He , linux-clk@vger.kernel.org Subject: Re: [PATCH][next] clk: ls1028a: fix a dereference of pointer 'parent' before a null check Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: alot/0.8.1 Date: Mon, 03 Feb 2020 23:03:53 -0800 Message-Id: <20200204070354.AB16A20674@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Colin King (2020-02-03 14:37:36) > From: Colin Ian King >=20 > Currently the pointer 'parent' is being dereferenced before it is > being null checked. Fix this by performing the null check before > it is dereferenced. >=20 > Addresses-Coverity: ("Dereference before null check") > Fixes: d37010a3c162 ("clk: ls1028a: Add clock driver for Display output i= nterface") > Signed-off-by: Colin Ian King > --- Applied to clk-next