Re: [PATCH v2 01/16] ARM: vexpress: Move vexpress_flags_set() into arch code

Lee Jones
2020-05-04T08:56:21Z

On Wed, 29 Apr 2020, Rob Herring wrote:

> vexpress_flags_set() is only used by the platform SMP related code and
> has nothing to do with the vexpress-sysreg MFD driver other than both
> access the same h/w block. It's also only needed for 32-bit systems and
> must be built-in for them. Let's move vexpress_flags_set() closer to
> where it is being used. This will allow for vexpress-sysreg to be built
> as a module.
>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/mach-vexpress/Kconfig | 1 -
> arch/arm/mach-vexpress/core.h | 1 +
> arch/arm/mach-vexpress/dcscb.c | 1 +
> arch/arm/mach-vexpress/v2m.c | 23 +++++++++++++++++++++++

> drivers/mfd/vexpress-sysreg.c | 19 -------------------

Acked-by: Lee Jones <lee.jones@linaro.org>

> include/linux/vexpress.h | 4 ----
> 6 files changed, 25 insertions(+), 24 deletions(-)

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog