linux-clk.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures
@ 2020-06-09 21:18 Stephen Boyd
  2020-06-18 10:42 ` Macpaul Lin
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Boyd @ 2020-06-09 21:18 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd
  Cc: linux-kernel, linux-clk, Owen Chen, Mars Cheng, Macpaul Lin,
	kbuild test robot

These aren't used and the macros that reference them aren't used either.
Remove the dead code to avoid compile warnings.

Cc: Owen Chen <owen.chen@mediatek.com>
Cc: Mars Cheng <mars.cheng@mediatek.com>
Cc: Macpaul Lin <macpaul.lin@mediatek.com>
Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
index 3ec53cb62ece..db8db1b3b79d 100644
--- a/drivers/clk/mediatek/clk-mt6765.c
+++ b/drivers/clk/mediatek/clk-mt6765.c
@@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
 	GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
 };
 
-static const struct mtk_gate_regs ifr0_cg_regs = {
-	.set_ofs = 0x200,
-	.clr_ofs = 0x200,
-	.sta_ofs = 0x200,
-};
-
-static const struct mtk_gate_regs ifr1_cg_regs = {
-	.set_ofs = 0x74,
-	.clr_ofs = 0x74,
-	.sta_ofs = 0x74,
-};
-
 static const struct mtk_gate_regs ifr2_cg_regs = {
 	.set_ofs = 0x80,
 	.clr_ofs = 0x84,
@@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
 	.sta_ofs = 0xc8,
 };
 
-#define GATE_IFR0(_id, _name, _parent, _shift) {	\
-		.id = _id,				\
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr0_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
-	}
-
-#define GATE_IFR1(_id, _name, _parent, _shift) {	\
-		.id = _id,				\
-		.name = _name,				\
-		.parent_name = _parent,			\
-		.regs = &ifr1_cg_regs,			\
-		.shift = _shift,			\
-		.ops = &mtk_clk_gate_ops_no_setclr,	\
-	}
-
 #define GATE_IFR2(_id, _name, _parent, _shift) {	\
 		.id = _id,				\
 		.name = _name,				\
-- 
Sent by a computer, using git, on the internet


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures
  2020-06-09 21:18 [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures Stephen Boyd
@ 2020-06-18 10:42 ` Macpaul Lin
  0 siblings, 0 replies; 2+ messages in thread
From: Macpaul Lin @ 2020-06-18 10:42 UTC (permalink / raw)
  To: Stephen Boyd
  Cc: Michael Turquette, linux-kernel, linux-clk, Owen Chen, Mars Cheng,
	kbuild test robot

On Tue, 2020-06-09 at 14:18 -0700, Stephen Boyd wrote:
> These aren't used and the macros that reference them aren't used either.
> Remove the dead code to avoid compile warnings.
> 
> Cc: Owen Chen <owen.chen@mediatek.com>
> Cc: Mars Cheng <mars.cheng@mediatek.com>
> Cc: Macpaul Lin <macpaul.lin@mediatek.com>
> Fixes: 1aca9939bf72 ("clk: mediatek: Add MT6765 clock support")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
> ---
>  drivers/clk/mediatek/clk-mt6765.c | 30 ------------------------------
>  1 file changed, 30 deletions(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt6765.c b/drivers/clk/mediatek/clk-mt6765.c
> index 3ec53cb62ece..db8db1b3b79d 100644
> --- a/drivers/clk/mediatek/clk-mt6765.c
> +++ b/drivers/clk/mediatek/clk-mt6765.c
> @@ -534,18 +534,6 @@ static const struct mtk_gate top_clks[] = {
>  	GATE_TOP2(CLK_TOP_APLL12_DIV3, "apll12_div3", "aud_1_ck", 5),
>  };
>  
> -static const struct mtk_gate_regs ifr0_cg_regs = {
> -	.set_ofs = 0x200,
> -	.clr_ofs = 0x200,
> -	.sta_ofs = 0x200,
> -};
> -
> -static const struct mtk_gate_regs ifr1_cg_regs = {
> -	.set_ofs = 0x74,
> -	.clr_ofs = 0x74,
> -	.sta_ofs = 0x74,
> -};
> -
>  static const struct mtk_gate_regs ifr2_cg_regs = {
>  	.set_ofs = 0x80,
>  	.clr_ofs = 0x84,
> @@ -570,24 +558,6 @@ static const struct mtk_gate_regs ifr5_cg_regs = {
>  	.sta_ofs = 0xc8,
>  };
>  
> -#define GATE_IFR0(_id, _name, _parent, _shift) {	\
> -		.id = _id,				\
> -		.name = _name,				\
> -		.parent_name = _parent,			\
> -		.regs = &ifr0_cg_regs,			\
> -		.shift = _shift,			\
> -		.ops = &mtk_clk_gate_ops_no_setclr_inv,	\
> -	}
> -
> -#define GATE_IFR1(_id, _name, _parent, _shift) {	\
> -		.id = _id,				\
> -		.name = _name,				\
> -		.parent_name = _parent,			\
> -		.regs = &ifr1_cg_regs,			\
> -		.shift = _shift,			\
> -		.ops = &mtk_clk_gate_ops_no_setclr,	\
> -	}
> -
>  #define GATE_IFR2(_id, _name, _parent, _shift) {	\
>  		.id = _id,				\
>  		.name = _name,				\

Thank you so much!
Owen and I were busy in other issues hence cannot help fix this issue
in time.

Thanks a lot!
BR,
Macpaul Lin

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-18 10:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-09 21:18 [PATCH] clk: mediatek: Remove ifr{0,1}_cfg_regs structures Stephen Boyd
2020-06-18 10:42 ` Macpaul Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).