Re: [PATCH v3 07/14] dt-bindings: thermal: imx8mm-thermal: Add i.MX 8M Nano compatible

Daniel Lezcano
2020-09-19T11:48:54Z

On 04/09/2020 17:23, Krzysztof Kozlowski wrote:
> DTSes with new i.MX 8M SoCs introduce their own compatibles so add them
> to fix dtbs_check warnings like:
>
> arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
> compatible:0: 'fsl,imx8mn-tmu' is not one of ['fsl,imx8mm-tmu', 'fsl,imx8mp-tmu']
> From schema: Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
>
> arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
> compatible: ['fsl,imx8mn-tmu', 'fsl,imx8mm-tmu'] is too long
>
> arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: tmu@30260000:
> compatible: Additional items are not allowed ('fsl,imx8mm-tmu' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---

Shall I pick this patch separately or did you merge the entire series ?

> .../devicetree/bindings/thermal/imx8mm-thermal.yaml | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
> index 38852877b8e3..89c54e08ee61 100644
> --- a/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/imx8mm-thermal.yaml
> @@ -18,9 +18,13 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - fsl,imx8mm-tmu
> - - fsl,imx8mp-tmu
> + oneOf:
> + - enum:
> + - fsl,imx8mm-tmu
> + - fsl,imx8mp-tmu
> + - items:
> + - const: fsl,imx8mn-tmu
> + - const: fsl,imx8mm-tmu
>
> reg:
> maxItems: 1
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |