From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A90EC43461 for ; Sun, 13 Sep 2020 04:00:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0714F217BA for ; Sun, 13 Sep 2020 04:00:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r9Aj14+l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725924AbgIMEA4 (ORCPT ); Sun, 13 Sep 2020 00:00:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbgIMEAx (ORCPT ); Sun, 13 Sep 2020 00:00:53 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E4B4C061573 for ; Sat, 12 Sep 2020 21:00:52 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id x69so13925238oia.8 for ; Sat, 12 Sep 2020 21:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Qi5BgYlxZ+ct/MUg8TILEG4D9MjaZLwf9MYNlT0Qzno=; b=r9Aj14+lIdavpJ+NJsWC5vYv24n/3JKlHJXYauYP+KP7wRy0NBwYopDsVwkaJh2/jI 4O7ffbUlthukJ/+7JpBwOKJ93Un7onuHbmbYPot5XtgB0Z8Fm4GnsrTPWGZk1EaElfBA uAXX48ChLHVnn9YRpRE7OCCpNmN1ilxu/5apivEkTnrKKoluIxKxKdRDoTRbxHqaXepE 8whj2m0loKB+t8CjS/jttbE6Fg/lulMCeHe230kkl/tYy73Yxs/1fYd/pwYzp/nD4OQ+ 3FuDYHWzIHBGUy3Na5SsTS7EGbuYCoOu+/aokDzh8ENfnyaDNSPne/knkGCwN97gFbwH VtDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Qi5BgYlxZ+ct/MUg8TILEG4D9MjaZLwf9MYNlT0Qzno=; b=ocgAf19+/165tOmDorxe5ntg2J5YyFef+k1jTg7bKIic54FB1MYU/pxE3chcYQTWet qfll7F1olZHXjTkWHm4+XggOsnyZea3Gim6CXULY2YmDrAKuq7V/ef1AC7/3siCCFcGe RHRmvG+22H9B6ctNA18UXEOZb821PLqpl6va+cxEOr1TB8WtTkiRTfq8ehF/LCkTTUKT YVQbyoKRW8mpIbamUE5N4J+xu7KzWC05Kb3rYEQm+SjjIZzeVPD9WmXUbaTXGShBtwcj /esWVKCSmZwqhZ/bl6SpFav9C1Zyj/Ug9RO3QMCRk9M+g5H6LXooFRQPaNm7vykv9NmG 3Ezw== X-Gm-Message-State: AOAM5309nOPiqmsbIDRyahOCo71N411Jzj8Wk1vkb9YIabl+91/2NmoC 3oG/Y4guL6CJjZda5UC7O9n9sw== X-Google-Smtp-Source: ABdhPJwNYI3tbmjRhOMPSg1q/E9ENKcpMD3csMUaeIexQSGGM27buobS7pe4XCQ3RS+eggJQ6MS3lg== X-Received: by 2002:aca:1a09:: with SMTP id a9mr5074891oia.164.1599969651969; Sat, 12 Sep 2020 21:00:51 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id o108sm1228694ota.25.2020.09.12.21.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 21:00:50 -0700 (PDT) Date: Sat, 12 Sep 2020 23:00:48 -0500 From: Bjorn Andersson To: Jason Yan Cc: agross@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot Subject: Re: [PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables Message-ID: <20200913040048.GW3715@yoga> References: <20200911013722.1459387-1-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200911013722.1459387-1-yanaijie@huawei.com> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu 10 Sep 20:37 CDT 2020, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/clk/qcom/gcc-msm8939.c:610:32: warning: > ‘gcc_xo_gpll6_gpll0a_map’ defined but not used > [-Wunused-const-variable=] > static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = { > ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’ > defined but not used [-Wunused-const-variable=] > static const struct parent_map gcc_xo_gpll6_gpll0_map[] = { > ^~~~~~~~~~~~~~~~~~~~~~ > Reviewed-by: Bjorn Andersson > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > drivers/clk/qcom/gcc-msm8939.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c > index 778354f82b1e..39ebb443ae3d 100644 > --- a/drivers/clk/qcom/gcc-msm8939.c > +++ b/drivers/clk/qcom/gcc-msm8939.c > @@ -595,24 +595,12 @@ static const struct clk_parent_data gcc_xo_gpll1_emclk_sleep_parent_data[] = { > { .fw_name = "sleep_clk", .name = "sleep_clk" }, > }; > > -static const struct parent_map gcc_xo_gpll6_gpll0_map[] = { > - { P_XO, 0 }, > - { P_GPLL6, 1 }, > - { P_GPLL0, 2 }, > -}; > - > static const struct clk_parent_data gcc_xo_gpll6_gpll0_parent_data[] = { > { .fw_name = "xo" }, > { .hw = &gpll6_vote.hw }, > { .hw = &gpll0_vote.hw }, > }; > > -static const struct parent_map gcc_xo_gpll6_gpll0a_map[] = { > - { P_XO, 0 }, > - { P_GPLL6, 1 }, > - { P_GPLL0_AUX, 2 }, > -}; > - > static const struct clk_parent_data gcc_xo_gpll6_gpll0a_parent_data[] = { > { .fw_name = "xo" }, > { .hw = &gpll6_vote.hw }, > -- > 2.25.4 >