From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DD46C00A89 for ; Mon, 2 Nov 2020 23:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3ED52225E for ; Mon, 2 Nov 2020 23:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604361146; bh=f7s3D49TOtYE8QyV/cjeavqKhcKCcZ3+a8aGAtJXWl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=r8MEtBD3GczpC7PfFIbyBQEf3heVi4LuHKu8LM1nh1OhJ6mBdtlSt7LJjekdQZlQ2 QNKGwrgNgZSGckU2b+fyKoNF4JD6iB18co2OJyf2lt9uc8LNGBtWqLF3AOxE1vQf1s e9Vral+2ktSDrBhkxG4kKUF0XF4OjwZruo0Or8l0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725869AbgKBXwZ (ORCPT ); Mon, 2 Nov 2020 18:52:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:36304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725841AbgKBXwZ (ORCPT ); Mon, 2 Nov 2020 18:52:25 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 05712207C4; Mon, 2 Nov 2020 23:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604361144; bh=f7s3D49TOtYE8QyV/cjeavqKhcKCcZ3+a8aGAtJXWl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UA92Oc8qZHT67MNv/dtw8V952ib+nKyWbMvJ7pP+Y6mpC8m5tVYWYmgUPJ4oBhYDT BkVTX0bExp1pifjBSFvywAyE7wZLGG5w3eVDFpaHKKVj7N6o6TvIc4DmrrkSrnumEo /NAtSo/fwViV618kSDk9oCdk+opBXJrY8alSsciI= Date: Tue, 3 Nov 2020 07:52:19 +0800 From: Shawn Guo To: Randy Dunlap Cc: Valdis =?utf-8?Q?Kl=C4=93tnieks?= , Dong Aisheng , Michael Turquette , Stephen Boyd , Sascha Hauer , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o Message-ID: <20201102235218.GY31601@dragon> References: <208469.1604318525@turing-police> <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org> <238534.1604350899@turing-police> <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Mon, Nov 02, 2020 at 01:31:59PM -0800, Randy Dunlap wrote: > On 11/2/20 1:01 PM, Valdis Klētnieks wrote: > > On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said: > > > >> also > >> Reported-by: kernel test robot > >> > >> However, this driver does not directly use . > > > > Just my luck - I looked at 3 or 4 other things that include of_platform.h > > and they all *did* include module.h. > > > >> platform_device.h #includes , which is where the > >> problem lies: > >> > >> uses macros that are provided by > >> so should #include . > >> > >> and that fixes this commit: > >> > >> commit 4c002c978b7f2f2306d53de051c054504af920a9 > >> Author: Greg Kroah-Hartman > >> Date: Mon Dec 9 20:33:03 2019 +0100 > >> > >> device.h: move 'struct driver' stuff out to device/driver.h > > > > OK.. who's going to do that? Me, or Randy, or Greg? > > You could go ahead... I began on it yesterday but didn't finish > testing, although I did see the same build error that the 0day > bot reported, so I don't know what it's going to take to fix that. It's a driver problem which is being addressed by Dong's patch[1]. Shawn [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201030153733.30160-1-aisheng.dong@nxp.com/