From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 821B5C2D0A3 for ; Tue, 3 Nov 2020 10:59:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13F44208B6 for ; Tue, 3 Nov 2020 10:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604401174; bh=qeFHNu/TjXZ28G/HeWCLlB9Rs2ZplrmupeH3I17qMMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1nili4gJRGiVzDUY0aejpRpZYC1XdnpYB2rR83YRLJSOFgTPwRvAsTx7QUChR6xfB 19r1z75UIy0bFe+U7NG297b4bICSE78P5aei+S1m6u3fsQUNm3LqzY1CK9ykpTIMf0 545iy74xjGNnDQSKadcDWI5ZywWH5EJbku6d95wI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726690AbgKCK7b (ORCPT ); Tue, 3 Nov 2020 05:59:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:35714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbgKCK7b (ORCPT ); Tue, 3 Nov 2020 05:59:31 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8187E208B6; Tue, 3 Nov 2020 10:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604401170; bh=qeFHNu/TjXZ28G/HeWCLlB9Rs2ZplrmupeH3I17qMMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HadCM52Fwbr7Bx14vtSn0XROrJ8NOI4lvGa9Z6yvwyCKfe+iRQQWW8v0fsMhNGO9z thkVfnxg5XVNLXsTNQ9KHORuVy+F1v9yW+TjXsMRCcxq+KqT9mXwIgLzLJdEuF0pC5 a2s0kWuQWNQm1m8bOASANQwMaao/XBwOpy/ZkVkA= Date: Tue, 3 Nov 2020 18:59:25 +0800 From: Shawn Guo To: Peng Fan , Stephen Boyd Cc: "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa , "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Aisheng Dong Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration Message-ID: <20201103105924.GD31601@dragon> References: <1604229834-25594-1-git-send-email-peng.fan@nxp.com> <20201103000657.GA31601@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Nov 03, 2020 at 01:03:44AM +0000, Peng Fan wrote: > Shawn, > > > Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration > > > > On Sun, Nov 01, 2020 at 07:23:54PM +0800, peng.fan@nxp.com wrote: > > > From: Peng Fan > > > > > > noc/axi/ahb are bus clk, not peripheral clk. > > > Since peripheral clk has a limitation that for peripheral clock slice, > > > IP clock slices must be stopped to change the clock source. > > > > > > However if the bus clk is marked as critical clk peripheral, the > > > assigned clock parent operation will fail. > > > > > > So we added CLK_SET_PARENT_GATE flag to avoid glitch. > > > > > > And add imx8m_clk_hw_composite_bus_critical for bus critical clock > > > usage > > > > > > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags") > > > Reviewed-by: Abel Vesa > > > Reported-by: Abel Vesa > > > Signed-off-by: Peng Fan > > > > Do you want this be picked up as a fix for 5.10-rc or non-critical stuff for > > -next? > > Please take this as a fix for 5.10-rc. Okay, I will leave this to Stephen then. Shawn