Re: [PATCH 1/4] dt-bindings: clock: Add SDX55 GCC clock bindings

Manivannan Sadhasivam
2020-10-31T03:29:55Z

Hi Rob,

On Fri, Oct 30, 2020 at 02:22:25PM -0500, Rob Herring wrote:
> On Wed, Oct 28, 2020 at 01:12:29PM +0530, Manivannan Sadhasivam wrote:
> > From: Vinod Koul <vkoul@kernel.org>
> >
> > Add device tree bindings for global clock controller on SDX55 SoCs.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> This should carry your S-o-b too.
>

Ah yes!

> > ---
> > .../bindings/clock/qcom,gcc-sdx55.yaml | 71 +++++++++++
> > include/dt-bindings/clock/qcom,gcc-sdx55.h | 112 ++++++++++++++++++
> > 2 files changed, 183 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-sdx55.yaml
> > create mode 100644 include/dt-bindings/clock/qcom,gcc-sdx55.h
> >

[...]

> > diff --git a/include/dt-bindings/clock/qcom,gcc-sdx55.h b/include/dt-bindings/clock/qcom,gcc-sdx55.h
> > new file mode 100644
> > index 000000000000..09ca45c6de73
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/qcom,gcc-sdx55.h
> > @@ -0,0 +1,112 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
>
> Dual license?
>

The downstream code just lists the GPL2.0 and I'm not sure if I can make
it as dual license. Whereas the binding we made it dual license since we
authored it.

Thanks,
Mani

> > +/*
> > + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2020, Linaro Ltd.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_CLK_QCOM_GCC_SDX55_H
> > +#define _DT_BINDINGS_CLK_QCOM_GCC_SDX55_H
> > +
> > +#define GPLL0 3
> > +#define GPLL0_OUT_EVEN 4
> > +#define GPLL4 5
> > +#define GPLL4_OUT_EVEN 6
> > +#define GPLL5 7
> > +#define GCC_AHB_PCIE_LINK_CLK 8
> > +#define GCC_BLSP1_AHB_CLK 9
> > +#define GCC_BLSP1_QUP1_I2C_APPS_CLK 10
> > +#define GCC_BLSP1_QUP1_I2C_APPS_CLK_SRC 11
> > +#define GCC_BLSP1_QUP1_SPI_APPS_CLK 12
> > +#define GCC_BLSP1_QUP1_SPI_APPS_CLK_SRC 13
> > +#define GCC_BLSP1_QUP2_I2C_APPS_CLK 14
> > +#define GCC_BLSP1_QUP2_I2C_APPS_CLK_SRC 15
> > +#define GCC_BLSP1_QUP2_SPI_APPS_CLK 16
> > +#define GCC_BLSP1_QUP2_SPI_APPS_CLK_SRC 17
> > +#define GCC_BLSP1_QUP3_I2C_APPS_CLK 18
> > +#define GCC_BLSP1_QUP3_I2C_APPS_CLK_SRC 19
> > +#define GCC_BLSP1_QUP3_SPI_APPS_CLK 20
> > +#define GCC_BLSP1_QUP3_SPI_APPS_CLK_SRC 21
> > +#define GCC_BLSP1_QUP4_I2C_APPS_CLK 22
> > +#define GCC_BLSP1_QUP4_I2C_APPS_CLK_SRC 23
> > +#define GCC_BLSP1_QUP4_SPI_APPS_CLK 24
> > +#define GCC_BLSP1_QUP4_SPI_APPS_CLK_SRC 25
> > +#define GCC_BLSP1_UART1_APPS_CLK 26
> > +#define GCC_BLSP1_UART1_APPS_CLK_SRC 27
> > +#define GCC_BLSP1_UART2_APPS_CLK 28
> > +#define GCC_BLSP1_UART2_APPS_CLK_SRC 29
> > +#define GCC_BLSP1_UART3_APPS_CLK 30
> > +#define GCC_BLSP1_UART3_APPS_CLK_SRC 31
> > +#define GCC_BLSP1_UART4_APPS_CLK 32
> > +#define GCC_BLSP1_UART4_APPS_CLK_SRC 33
> > +#define GCC_BOOT_ROM_AHB_CLK 34
> > +#define GCC_CE1_AHB_CLK 35
> > +#define GCC_CE1_AXI_CLK 36
> > +#define GCC_CE1_CLK 37
> > +#define GCC_CPUSS_AHB_CLK 38
> > +#define GCC_CPUSS_AHB_CLK_SRC 39
> > +#define GCC_CPUSS_GNOC_CLK 40
> > +#define GCC_CPUSS_RBCPR_CLK 41
> > +#define GCC_CPUSS_RBCPR_CLK_SRC 42
> > +#define GCC_EMAC_CLK_SRC 43
> > +#define GCC_EMAC_PTP_CLK_SRC 44
> > +#define GCC_ETH_AXI_CLK 45
> > +#define GCC_ETH_PTP_CLK 46
> > +#define GCC_ETH_RGMII_CLK 47
> > +#define GCC_ETH_SLAVE_AHB_CLK 48
> > +#define GCC_GP1_CLK 49
> > +#define GCC_GP1_CLK_SRC 50
> > +#define GCC_GP2_CLK 51
> > +#define GCC_GP2_CLK_SRC 52
> > +#define GCC_GP3_CLK 53
> > +#define GCC_GP3_CLK_SRC 54
> > +#define GCC_PCIE_0_CLKREF_CLK 55
> > +#define GCC_PCIE_AUX_CLK 56
> > +#define GCC_PCIE_AUX_PHY_CLK_SRC 57
> > +#define GCC_PCIE_CFG_AHB_CLK 58
> > +#define GCC_PCIE_MSTR_AXI_CLK 59
> > +#define GCC_PCIE_PIPE_CLK 60
> > +#define GCC_PCIE_RCHNG_PHY_CLK 61
> > +#define GCC_PCIE_RCHNG_PHY_CLK_SRC 62
> > +#define GCC_PCIE_SLEEP_CLK 63
> > +#define GCC_PCIE_SLV_AXI_CLK 64
> > +#define GCC_PCIE_SLV_Q2A_AXI_CLK 65
> > +#define GCC_PDM2_CLK 66
> > +#define GCC_PDM2_CLK_SRC 67
> > +#define GCC_PDM_AHB_CLK 68
> > +#define GCC_PDM_XO4_CLK 69
> > +#define GCC_SDCC1_AHB_CLK 70
> > +#define GCC_SDCC1_APPS_CLK 71
> > +#define GCC_SDCC1_APPS_CLK_SRC 72
> > +#define GCC_SYS_NOC_CPUSS_AHB_CLK 73
> > +#define GCC_USB30_MASTER_CLK 74
> > +#define GCC_USB30_MASTER_CLK_SRC 75
> > +#define GCC_USB30_MOCK_UTMI_CLK 76
> > +#define GCC_USB30_MOCK_UTMI_CLK_SRC 77
> > +#define GCC_USB30_MSTR_AXI_CLK 78
> > +#define GCC_USB30_SLEEP_CLK 79
> > +#define GCC_USB30_SLV_AHB_CLK 80
> > +#define GCC_USB3_PHY_AUX_CLK 81
> > +#define GCC_USB3_PHY_AUX_CLK_SRC 82
> > +#define GCC_USB3_PHY_PIPE_CLK 83
> > +#define GCC_USB3_PRIM_CLKREF_CLK 84
> > +#define GCC_USB_PHY_CFG_AHB2PHY_CLK 85
> > +#define GCC_XO_DIV4_CLK 86
> > +#define GCC_XO_PCIE_LINK_CLK 87
> > +
> > +#define GCC_EMAC_BCR 0
> > +#define GCC_PCIE_BCR 1
> > +#define GCC_PCIE_LINK_DOWN_BCR 2
> > +#define GCC_PCIE_NOCSR_COM_PHY_BCR 3
> > +#define GCC_PCIE_PHY_BCR 4
> > +#define GCC_PCIE_PHY_CFG_AHB_BCR 5
> > +#define GCC_PCIE_PHY_COM_BCR 6
> > +#define GCC_PCIE_PHY_NOCSR_COM_PHY_BCR 7
> > +#define GCC_PDM_BCR 8
> > +#define GCC_QUSB2PHY_BCR 9
> > +#define GCC_TCSR_PCIE_BCR 10
> > +#define GCC_USB30_BCR 11
> > +#define GCC_USB3_PHY_BCR 12
> > +#define GCC_USB3PHY_PHY_BCR 13
> > +#define GCC_USB_PHY_CFG_AHB2PHY_BCR 14
> > +
> > +#endif
> > --
> > 2.17.1
> >