Linux clock framework development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	mturquette@baylibre.com
Cc: kbuild-all@lists.01.org, sboyd@kernel.org, robh+dt@kernel.org,
	tsbogend@alpha.franken.de, john@phrozen.org,
	gregkh@linuxfoundation.org, gch981213@gmail.com,
	hackpascal@gmail.com, jiaxun.yang@flygoat.com,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 3/5] clk: ralink: add clock driver for mt7621 SoC
Date: Fri, 13 Nov 2020 22:17:43 +0800	[thread overview]
Message-ID: <202011132226.NzPxhl8c-lkp@intel.com> (raw)
In-Reply-To: <20201113091046.30964-4-sergio.paracuellos@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2950 bytes --]

Hi Sergio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on staging/staging-testing robh/for-next linus/master v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sergio-Paracuellos/MIPS-ralink-add-CPU-clock-detection-and-clock-gate-driver-for-MT7621/20201113-171221
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e9751b3fda8fd54952502ec81fddc61c80347155
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sergio-Paracuellos/MIPS-ralink-add-CPU-clock-detection-and-clock-gate-driver-for-MT7621/20201113-171221
        git checkout e9751b3fda8fd54952502ec81fddc61c80347155
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/clk/ralink/clk-mt7621.c: In function 'mt7621_register_top_clocks':
>> drivers/clk/ralink/clk-mt7621.c:299:3: warning: ignoring return value of 'of_clk_hw_register', declared with attribute warn_unused_result [-Wunused-result]
     299 |   of_clk_hw_register(clk_prov->node, &sclk->hw);
         |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/clk/ralink/clk-mt7621.c: In function 'mt7621_gate_ops_init':
   drivers/clk/ralink/clk-mt7621.c:155:2: warning: ignoring return value of 'of_clk_hw_register', declared with attribute warn_unused_result [-Wunused-result]
     155 |  of_clk_hw_register(np, &sclk->hw);
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/of_clk_hw_register +299 drivers/clk/ralink/clk-mt7621.c

   288	
   289	static void mt7621_register_top_clocks(struct mt7621_clk_provider *clk_prov)
   290	{
   291		struct clk_hw_onecell_data **clk_data = &clk_prov->clk_data;
   292		struct clk_hw **hws = (*clk_data)->hws;
   293		int i;
   294	
   295		for (i = 0; i < ARRAY_SIZE(mt7621_clks_base); i++) {
   296			struct mt7621_clk *sclk = &mt7621_clks_base[i];
   297	
   298			sclk->clk_prov = clk_prov;
 > 299			of_clk_hw_register(clk_prov->node, &sclk->hw);
   300			hws[i] = &sclk->hw;
   301			(*clk_data)->num++;
   302		}
   303	}
   304	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69073 bytes --]

  reply	other threads:[~2020-11-13 14:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  9:10 [PATCH v2 0/5] MIPS: ralink: add CPU clock detection and clock gate driver for MT7621 Sergio Paracuellos
2020-11-13  9:10 ` [PATCH v2 1/5] dt-bindings: clock: add dt binding header for mt7621 clocks Sergio Paracuellos
2020-11-13  9:10 ` [PATCH v2 2/5] dt: bindings: add mt7621-clk device tree binding documentation Sergio Paracuellos
2020-11-13  9:10 ` [PATCH v2 3/5] clk: ralink: add clock driver for mt7621 SoC Sergio Paracuellos
2020-11-13 14:17   ` kernel test robot [this message]
2020-11-13 15:02     ` Sergio Paracuellos
2020-11-13  9:10 ` [PATCH v2 4/5] staging: mt7621-dts: make use of new 'mt7621-clk' Sergio Paracuellos
2020-11-13  9:10 ` [PATCH v2 5/5] MAINTAINERS: add MT7621 CLOCK maintainer Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011132226.NzPxhl8c-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gch981213@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hackpascal@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=john@phrozen.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox