From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: agross@kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, robh+dt@kernel.org, sboyd@kernel.org,
mturquette@baylibre.com, linux-arm-msm@vger.kernel.org,
linux-crypto@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource
Date: Tue, 17 Nov 2020 21:57:49 -0600 [thread overview]
Message-ID: <20201118035749.GA8532@builder.lan> (raw)
In-Reply-To: <20201117134714.3456446-2-thara.gopinath@linaro.org>
On Tue 17 Nov 07:47 CST 2020, Thara Gopinath wrote:
> Add clock id forc CE clock resource which is required to bring up the
> crypto engine on sdm845.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
$subject should have bindings in plural to match other changes and a
space after the ':'
Apart from that, things looks good.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> include/dt-bindings/clock/qcom,rpmh.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/dt-bindings/clock/qcom,rpmh.h b/include/dt-bindings/clock/qcom,rpmh.h
> index 2e6c54e65455..30111c8f7fe9 100644
> --- a/include/dt-bindings/clock/qcom,rpmh.h
> +++ b/include/dt-bindings/clock/qcom,rpmh.h
> @@ -21,5 +21,6 @@
> #define RPMH_IPA_CLK 12
> #define RPMH_LN_BB_CLK1 13
> #define RPMH_LN_BB_CLK1_A 14
> +#define RPMH_CE_CLK 15
>
> #endif
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-11-18 3:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 13:47 [PATCH 0/6] Enable Qualcomm Crypto Engine on sdm845 Thara Gopinath
2020-11-17 13:47 ` [PATCH 1/6] dt-binding:clock: Add entry for crypto engine RPMH clock resource Thara Gopinath
2020-11-18 3:57 ` Bjorn Andersson [this message]
2020-11-17 13:47 ` [PATCH 2/6] clk:qcom:rpmh: Add CE clock on sdm845 Thara Gopinath
2020-11-18 3:59 ` Bjorn Andersson
2020-11-17 13:47 ` [PATCH 3/6] drivers:crypto:qce: Enable support for crypto engine " Thara Gopinath
2020-11-18 4:02 ` Bjorn Andersson
2020-11-17 13:47 ` [PATCH 4/6] drivers:crypto:qce: Fix SHA result buffer corruption issues Thara Gopinath
2020-11-18 4:04 ` Bjorn Andersson
2020-11-17 13:47 ` [PATCH 5/6] dts:qcom:sdm845: Add dt entries to support crypto engine Thara Gopinath
2020-11-18 4:10 ` Bjorn Andersson
2020-11-18 19:58 ` Thara Gopinath
2020-11-17 13:47 ` [PATCH 6/6] devicetree:bindings:crypto: Extend qcom-qce binding to add support for crypto engine version 5.4 Thara Gopinath
2020-11-18 4:08 ` Bjorn Andersson
2020-11-17 16:57 ` [PATCH 0/6] Enable Qualcomm Crypto Engine on sdm845 Eric Biggers
2020-11-17 18:07 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118035749.GA8532@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thara.gopinath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).