Re: [PATCH v4 4/7] drm: rockchip: add sound support to rk3066 hdmi driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

Hi Johan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rockchip/for-next]
[also build test WARNING on robh/for-next asoc/for-next sound/for-next v5.10-rc4 next-20201117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Johan-Jonker/Enable-rk3066a-HDMI-sound/20201118-034916
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4fd170243d9bc7618270dff969e138b05db0f945
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Johan-Jonker/Enable-rk3066a-HDMI-sound/20201118-034916
        git checkout 4fd170243d9bc7618270dff969e138b05db0f945
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_config_aai':
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c:227:31: warning: variable 'faudio' set but not used [-Wunused-but-set-variable]
     227 |  struct hdmi_audio_infoframe *faudio;
         |                               ^~~~~~

vim +/faudio +227 drivers/gpu/drm/rockchip/rk3066_hdmi.c

   223	
   224	static int rk3066_hdmi_config_aai(struct rk3066_hdmi *hdmi,
   225					  struct audio_info *audio)
   226	{
 > 227		struct hdmi_audio_infoframe *faudio;
   228		union hdmi_infoframe frame;
   229		int rc;
   230	
   231		rc = hdmi_audio_infoframe_init(&frame.audio);
   232		faudio = (struct hdmi_audio_infoframe *)&frame;
   233	
   234		return rk3066_hdmi_upload_frame(hdmi, rc, &frame,
   235						HDMI_INFOFRAME_AAI, 0, 0, 0);
   236	}
   237	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58112 bytes --]