Re: [PATCH v2 3/5] dt-bindings: clock: Add SM8350 GCC clock bindings

Vinod Koul
2020-12-11T04:31:09Z

On 10-12-20, 12:31, Stephen Boyd wrote:
> Quoting Vinod Koul (2020-12-09 22:11:59)
> > On 09-12-20, 22:01, Rob Herring wrote:
> > > On Tue, Dec 08, 2020 at 12:17:00PM +0530, Vinod Koul wrote:
> >
> > > > +required:
> > > > + - compatible
> > > > + - clocks
> > > > + - clock-names
> > > > + - reg
> > > > + - '#clock-cells'
> > > > + - '#reset-cells'
> > >
> > > You may or may not have power domains?
> >
> > I have not added them in the driver yet, so I dont think it made sense
> > to add them when they are not present. For basic stuff it is not
> > required but eventually yes, so I plan to update binding and driver at
> > that time
> >
>
> They should still be required in the binding though if the hardware has
> power domains. It's not like the hardware doesn't have power domains
> already or can gain that ability after the fact. The driver should deal
> with it when it is ready.

Yeah that is a valid argument, I will add and send updated revision

Thanks
--
~Vinod