Re: [PATCH v2 02/17] rtc: bd70528: Do not require parent data

Alexandre Belloni
2021-01-19T21:10:30Z

On 19/01/2021 09:14:45+0200, Matti Vaittinen wrote:
> The ROHM BD71828 and BD71815 RTC drivers only need the regmap
> pointer from parent. Regmap can be obtained via dev_get_regmap()
> so do not require parent to populate driver data for that.
>
> BD70528 on the other hand requires parent data to access the
> watchdog so leave the parent data for BD70528 here for now.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>
> Please note that this same change has been sent individually:
> https://lore.kernel.org/lkml/20210105152350.GA3714833@localhost.localdomain/
> It is present in this series only because some patches depend on it.
>

Then I think it is best to have it as part of this series.

> ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~

I've alway wanted to comment on that, should he have to say "I don't
think" to vanish ? Because saying "I don't think so," means that he
thinks this is not so.

> Simon says - in Latin please.
> ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~

And I guess this should be simply "non cogito" ;)

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering