From: Tudor Ambarus <tudor.ambarus@microchip.com>
To: <mturquette@baylibre.com>, <sboyd@kernel.org>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<ludovic.desroches@microchip.com>, <claudiu.beznea@microchip.com>,
<mirq-linux@rere.qmqm.pl>, <saravanak@google.com>
Cc: <gregkh@linuxfoundation.org>, <linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
"Tudor Ambarus" <tudor.ambarus@microchip.com>
Subject: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup
Date: Thu, 28 Jan 2021 12:44:46 +0200 [thread overview]
Message-ID: <20210128104446.164269-1-tudor.ambarus@microchip.com> (raw)
The sama5d2 requires the clock provider initialized before timers.
We can't use a platform driver for the sama5d2-pmc driver, as the
platform_bus_init() is called later on, after time_init().
As fw_devlink considers only devices, it does not know that the
pmc is ready. Hence probing of devices that depend on it fail:
probe deferral - supplier f0014000.pmc not ready
Fix this by setting the OF_POPULATED flag for the sama5d2_pmc
device node after successful setup. This will make
of_link_to_phandle() ignore the sama5d2_pmc device node as a
dependency, and consumer devices will be probed again.
Fixes: e590474768f1cc04 ("driver core: Set fw_devlink=on by default")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
---
I'll be out of office, will check the rest of the at91 SoCs
at the begining of next week.
drivers/clk/at91/sama5d2.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/at91/sama5d2.c b/drivers/clk/at91/sama5d2.c
index 9a5cbc7cd55a..5eea2b4a63dd 100644
--- a/drivers/clk/at91/sama5d2.c
+++ b/drivers/clk/at91/sama5d2.c
@@ -367,6 +367,8 @@ static void __init sama5d2_pmc_setup(struct device_node *np)
of_clk_add_hw_provider(np, of_clk_hw_pmc_get, sama5d2_pmc);
+ of_node_set_flag(np, OF_POPULATED);
+
return;
err_free:
--
2.25.1
next reply other threads:[~2021-01-28 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 10:44 Tudor Ambarus [this message]
2021-01-28 17:01 ` [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup Saravana Kannan
2021-02-01 10:54 ` Geert Uytterhoeven
2021-02-01 17:16 ` Saravana Kannan
2021-02-09 7:55 ` Stephen Boyd
2021-02-09 9:11 ` Saravana Kannan
2021-02-09 15:21 ` Tudor.Ambarus
2021-02-09 19:06 ` Saravana Kannan
2021-02-10 8:09 ` Tudor.Ambarus
2021-02-09 9:42 ` Tudor.Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128104446.164269-1-tudor.ambarus@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox