Re: [PATCH 10/40] mfd: ti_am335x_tscadc: Drop extra spacing when declaring stack variables

Jonathan Cameron
2021-08-30T12:49:12Z

On Wed, 25 Aug 2021 17:24:48 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Many variables will be updated (renamed, dropped, added) in the upcoming
> changes, so let's simplify the style to avoid messing with spaces over
> and over again.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
I agree with dropping the spaces, but not so much with reordering the elements.
Whilst it obviously doesn't make any difference to padding etc, it does
require more thought that I'd want to expend reviewing a patch like this
to establish whether there was a semantic meaning to the original order that
we are disrupting.

Jonathan

> ---
> drivers/mfd/ti_am335x_tscadc.c | 28 +++++++++++++---------------
> 1 file changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> index 540c6dcef541..f0824732badf 100644
> --- a/drivers/mfd/ti_am335x_tscadc.c
> +++ b/drivers/mfd/ti_am335x_tscadc.c
> @@ -113,18 +113,16 @@ static void tscadc_idle_config(struct ti_tscadc_dev *tscadc)
>
> static int ti_tscadc_probe(struct platform_device *pdev)
> {
> - struct ti_tscadc_dev *tscadc;
> - struct resource *res;
> - struct clk *clk;
> - struct device_node *node;
> - struct mfd_cell *cell;
> - struct property *prop;
> - const __be32 *cur;
> - u32 val;
> - int err, ctrl;
> - int clock_rate;
> - int tsc_wires = 0, adc_channels = 0, total_channels;
> - int readouts = 0;
> + struct ti_tscadc_dev *tscadc;
> + struct device_node *node;
> + struct property *prop;
> + struct mfd_cell *cell;
> + struct resource *res;
> + const __be32 *cur;
> + struct clk *clk;
> + u32 val;
> + int tsc_wires = 0, adc_channels = 0, readouts = 0;
> + int total_channels, clock_rate, ctrl, err;
>
> if (!pdev->dev.of_node) {
> dev_err(&pdev->dev, "Could not find valid DT data.\n");
> @@ -278,7 +276,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
>
> static int ti_tscadc_remove(struct platform_device *pdev)
> {
> - struct ti_tscadc_dev *tscadc = platform_get_drvdata(pdev);
> + struct ti_tscadc_dev *tscadc = platform_get_drvdata(pdev);
>
> regmap_write(tscadc->regmap, REG_SE, 0x00);
>
> @@ -297,7 +295,7 @@ static int __maybe_unused ti_tscadc_can_wakeup(struct device *dev, void *data)
>
> static int __maybe_unused tscadc_suspend(struct device *dev)
> {
> - struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
> + struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
>
> regmap_write(tscadc->regmap, REG_SE, 0x00);
> if (device_for_each_child(dev, NULL, ti_tscadc_can_wakeup)) {
> @@ -315,7 +313,7 @@ static int __maybe_unused tscadc_suspend(struct device *dev)
>
> static int __maybe_unused tscadc_resume(struct device *dev)
> {
> - struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
> + struct ti_tscadc_dev *tscadc = dev_get_drvdata(dev);
> u32 ctrl;
>
> pm_runtime_get_sync(dev);