From: Heiko Stuebner <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org
Cc: sboyd@kernel.org, kernel@esmil.dk, linux-clk@vger.kernel.org,
mturquette@baylibre.com, heiko@sntech.de
Subject: [PATCH 2/2] clk: rockchip: drop module parts from rk3399 and rk3568 drivers
Date: Wed, 27 Oct 2021 15:26:16 +0200 [thread overview]
Message-ID: <20211027132616.1039814-3-heiko@sntech.de> (raw)
In-Reply-To: <20211027132616.1039814-1-heiko@sntech.de>
Both of these drivers were converted to real drivers and got a tristate
build option. But them being builtin_platform_drivers, they only ever
should be build-in - as the name suggests.
So adapt the Kconfig symbol and drop the MODULE_* parts from the drivers.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/clk/rockchip/Kconfig | 4 ++--
drivers/clk/rockchip/clk-rk3399.c | 4 ----
drivers/clk/rockchip/clk-rk3568.c | 4 ----
3 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/rockchip/Kconfig b/drivers/clk/rockchip/Kconfig
index 2dfd6a383393..3067bdb6e119 100644
--- a/drivers/clk/rockchip/Kconfig
+++ b/drivers/clk/rockchip/Kconfig
@@ -80,14 +80,14 @@ config CLK_RK3368
Build the driver for RK3368 Clock Driver.
config CLK_RK3399
- tristate "Rockchip RK3399 clock controller support"
+ bool "Rockchip RK3399 clock controller support"
depends on ARM64 || COMPILE_TEST
default y
help
Build the driver for RK3399 Clock Driver.
config CLK_RK3568
- tristate "Rockchip RK3568 clock controller support"
+ bool "Rockchip RK3568 clock controller support"
depends on ARM64 || COMPILE_TEST
default y
help
diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
index 53ed5cca335b..306910a3a0d3 100644
--- a/drivers/clk/rockchip/clk-rk3399.c
+++ b/drivers/clk/rockchip/clk-rk3399.c
@@ -1630,7 +1630,6 @@ static const struct of_device_id clk_rk3399_match_table[] = {
},
{ }
};
-MODULE_DEVICE_TABLE(of, clk_rk3399_match_table);
static int __init clk_rk3399_probe(struct platform_device *pdev)
{
@@ -1657,6 +1656,3 @@ static struct platform_driver clk_rk3399_driver = {
},
};
builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
-
-MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
-MODULE_LICENSE("GPL");
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index 75ca855e720d..69a9e8069a48 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1693,7 +1693,6 @@ static const struct of_device_id clk_rk3568_match_table[] = {
},
{ }
};
-MODULE_DEVICE_TABLE(of, clk_rk3568_match_table);
static int __init clk_rk3568_probe(struct platform_device *pdev)
{
@@ -1720,6 +1719,3 @@ static struct platform_driver clk_rk3568_driver = {
},
};
builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
-
-MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
-MODULE_LICENSE("GPL");
--
2.30.2
next prev parent reply other threads:[~2021-10-27 13:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 13:26 [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling Heiko Stuebner
2021-10-27 13:26 ` [PATCH 1/2] Revert "clk: rockchip: use module_platform_driver_probe" Heiko Stuebner
2021-10-29 6:42 ` Stephen Boyd
2021-10-27 13:26 ` Heiko Stuebner [this message]
2021-10-29 6:42 ` [PATCH 2/2] clk: rockchip: drop module parts from rk3399 and rk3568 drivers Stephen Boyd
2021-10-27 20:27 ` [PATCH 0/2] clk: rockchip: cleanup errors in (module-)driver handling Stephen Boyd
2021-10-27 23:20 ` Heiko Stübner
2021-10-29 6:43 ` Stephen Boyd
2021-10-29 12:37 ` Heiko Stübner
2021-11-03 0:59 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027132616.1039814-3-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=kernel@esmil.dk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox