From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E148C433F5 for ; Tue, 25 Jan 2022 17:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237869AbiAYR0D (ORCPT ); Tue, 25 Jan 2022 12:26:03 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:47232 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1388991AbiAYRQW (ORCPT ); Tue, 25 Jan 2022 12:16:22 -0500 X-UUID: f466c55c129348a38ecb46b28d0a0a39-20220126 X-UUID: f466c55c129348a38ecb46b28d0a0a39-20220126 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 258942651; Wed, 26 Jan 2022 01:16:06 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Wed, 26 Jan 2022 01:16:05 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 Jan 2022 01:16:05 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 Jan 2022 01:16:04 +0800 From: Miles Chen To: CC: , , , , , , , Subject: Re: [PATCH 08/31] clk: mediatek: cpumux: Clean up included headers Date: Wed, 26 Jan 2022 01:16:04 +0800 Message-ID: <20220125171604.1548-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20220122091731.283592-9-wenst@chromium.org> References: <20220122091731.283592-9-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org > Some headers with the declaration of functions and structures aren't > directly included. Explicitly include them so that future changes to > other headers would not result in an unexpected build break. > > On the header side, add forward declarations for any data structures > whose pointers are used in function signatures. No headers are > required. > > Signed-off-by: Chen-Yu Tsai Reviewed-by: Miles Chen > --- > drivers/clk/mediatek/clk-cpumux.c | 3 +++ > drivers/clk/mediatek/clk-cpumux.h | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c > index 344c6399b22f..658aee789f44 100644 > --- a/drivers/clk/mediatek/clk-cpumux.c > +++ b/drivers/clk/mediatek/clk-cpumux.c > @@ -5,8 +5,11 @@ > */ > > #include > +#include > +#include > #include > #include > +#include > #include > > #include "clk-mtk.h" > diff --git a/drivers/clk/mediatek/clk-cpumux.h b/drivers/clk/mediatek/clk-cpumux.h > index a538f2bbef0d..b07e89f7c283 100644 > --- a/drivers/clk/mediatek/clk-cpumux.h > +++ b/drivers/clk/mediatek/clk-cpumux.h > @@ -7,6 +7,10 @@ > #ifndef __DRV_CLK_CPUMUX_H > #define __DRV_CLK_CPUMUX_H > > +struct clk_onecell_data; > +struct device_node; > +struct mtk_composite; > + > int mtk_clk_register_cpumuxes(struct device_node *node, > const struct mtk_composite *clks, int num, > struct clk_onecell_data *clk_data); > -- > 2.35.0.rc0.227.g00780c9af4-goog