From: Maxime Ripard <maxime@cerno.tech>
To: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
Maxime Ripard <maxime@cerno.tech>
Subject: [PATCH v5 06/11] clk: Add clk_drop_range
Date: Tue, 22 Feb 2022 14:18:48 +0100 [thread overview]
Message-ID: <20220222131853.198625-7-maxime@cerno.tech> (raw)
In-Reply-To: <20220222131853.198625-1-maxime@cerno.tech>
In order to reset the range on a clock, we need to call
clk_set_rate_range with a minimum of 0 and a maximum of ULONG_MAX. Since
it's fairly inconvenient, let's introduce a clk_drop_range() function
that will do just this.
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
drivers/clk/clk_test.c | 4 ++--
include/linux/clk.h | 11 +++++++++++
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c
index b23859d1b460..f108e2dcc351 100644
--- a/drivers/clk/clk_test.c
+++ b/drivers/clk/clk_test.c
@@ -640,7 +640,7 @@ static void clk_range_test_multiple_set_range_rate_maximized(struct kunit *test)
KUNIT_EXPECT_EQ(test, rate, DUMMY_CLOCK_RATE_1);
KUNIT_ASSERT_EQ(test,
- clk_set_rate_range(user2, 0, ULONG_MAX),
+ clk_drop_range(user2),
0);
rate = clk_get_rate(clk);
@@ -757,7 +757,7 @@ static void clk_range_test_multiple_set_range_rate_minimized(struct kunit *test)
KUNIT_EXPECT_EQ(test, rate, DUMMY_CLOCK_RATE_2);
KUNIT_ASSERT_EQ(test,
- clk_set_rate_range(user2, 0, ULONG_MAX),
+ clk_drop_range(user2),
0);
rate = clk_get_rate(clk);
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 266e8de3cb51..39faa54efe88 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -986,6 +986,17 @@ static inline void clk_bulk_disable_unprepare(int num_clks,
clk_bulk_unprepare(num_clks, clks);
}
+/**
+ * clk_drop_range - Reset any range set on that clock
+ * @clk: clock source
+ *
+ * Returns success (0) or negative errno.
+ */
+static inline int clk_drop_range(struct clk *clk)
+{
+ return clk_set_rate_range(clk, 0, ULONG_MAX);
+}
+
/**
* clk_get_optional - lookup and obtain a reference to an optional clock
* producer.
--
2.35.1
next prev parent reply other threads:[~2022-02-22 13:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 13:18 [PATCH v5 00/11] clk: Improve clock range handling Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 01/11] clk: Introduce Kunit Tests for the framework Maxime Ripard
2022-02-23 2:25 ` kernel test robot
2022-02-22 13:18 ` [PATCH v5 02/11] clk: Enforce that disjoints limits are invalid Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 03/11] clk: Always clamp the rounded rate Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 04/11] clk: Use clamp instead of open-coding our own Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 05/11] clk: Always set the rate on clk_set_range_rate Maxime Ripard
2022-02-22 13:18 ` Maxime Ripard [this message]
2022-02-22 13:18 ` [PATCH v5 07/11] clk: bcm: rpi: Add variant structure Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 08/11] clk: bcm: rpi: Set a default minimum rate Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 09/11] clk: bcm: rpi: Run some clocks at the minimum rate allowed Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 10/11] drm/vc4: Add logging and comments Maxime Ripard
2022-02-22 13:18 ` [PATCH v5 11/11] drm/vc4: hdmi: Remove clock rate initialization Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220222131853.198625-7-maxime@cerno.tech \
--to=maxime@cerno.tech \
--cc=dave.stevenson@raspberrypi.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phil@raspberrypi.com \
--cc=sboyd@kernel.org \
--cc=tim.gover@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox