Re: [PATCH v10 5/9] dmaengine: dw: dmamux: Introduce RZN1 DMA router support

Miquel Raynal
2022-04-13T13:10:25Z

Hi Andy,

andriy.shevchenko@linux.intel.com wrote on Wed, 13 Apr 2022 13:40:27
+0300:

> On Wed, Apr 13, 2022 at 09:53:09AM +0200, Geert Uytterhoeven wrote:
> > On Tue, Apr 12, 2022 at 9:39 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> ...
>
> > You might as well declare it in rzn1_dmamux_data as:
> >
> > unsigned long used_chans[BITS_TO_LONGS(2 * RZN1_DMAMUX_MAX_LINES)];

Now at the top of the driver I have

#define RZN1_DMAMUX_LINES 64
#define RZN1_DMAMUX_MAX_LINES 16

Which does not look right. So FYI I decided to change them to

#define RZN1_DMAMUX_MAX_LINES 64
#define RZN1_DMAMUX_LINES_PER_CTLR 16

which feels much more clear.

Thanks,
Miquèl