Re: [PATCH 18/48] ARM: pxa: hx4700: use gpio descriptors for audio

Mark Brown
2022-05-05T14:39:40Z

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Thu, May 05, 2022 at 04:33:06PM +0200, Linus Walleij wrote:
> On Thu, May 5, 2022 at 8:04 AM Arnd Bergmann <arnd@kernel.org> wrote:

> > /* Headphones jack detection DAPM pin */
> > static struct snd_soc_jack_pin hs_jack_pin[] = {
> > {
> > .pin = "Headphone Jack",
> > .mask = SND_JACK_HEADPHONE,
> > },
> > {
> > .pin = "Speaker",
> > /* disable speaker when hp jack is inserted */
> > .mask = SND_JACK_HEADPHONE,
> > .invert = 1,
> > },

> Hm some ASoC thingie. No idea what that is, but I suppose another
> place where a subsystem for legacy reasons try to do the gpiolib
> inversion on it's own accord. That one isn't flagged as active low in the
> descriptor so it's fine I guess.

It's saying that when the headphone is inserted the headphone output
should be enabled and the speaker output should be disabled, and vice
versa.

> Possible this should be fixed in ASoC to rely on gpiolib but we can't
> fix the entire world.

I don't think so.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]