From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 312AFC4332F for ; Wed, 11 May 2022 19:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345148AbiEKTWv (ORCPT ); Wed, 11 May 2022 15:22:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346758AbiEKTWU (ORCPT ); Wed, 11 May 2022 15:22:20 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A762764BF8 for ; Wed, 11 May 2022 12:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652296933; x=1683832933; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/bf8yyAfeLWIyXw2nbA35V2sE2tC6RAF//PrK5KXpTs=; b=Bx7W9jLseDBtTohjeXAXzJYLQWiPnjjk5aEFBq3DlhvOXp8UuhohrOQU c6P9jN0jzcZ9paeZZbPnqnS6Td2mVaf97SGxiba0uwK0o+rDDOcsfScYn ClK9Y9xPMxJhKG5FeeRqPNvd+klXn0yvIF8+WkvkstZdzURXZufFaxu7I M1xscU6gZtfDJ5vxY4zV8ZXtEkiCbIDhdc+atwBKPUWy3yPYvIDI6n4jp JGFneS/FI8+OgsTb2UZwWCO0dNW4CkObUTlyaW4BDIZs+IINEGImTWKS9 eKA/GEyNLMj+9KVdorNKWslo4U8ViR5DQb2V+jtPOY1WT4IFErOhibrxK w==; X-IronPort-AV: E=McAfee;i="6400,9594,10344"; a="250321812" X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="250321812" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 12:22:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,218,1647327600"; d="scan'208";a="814607794" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga006.fm.intel.com with ESMTP; 11 May 2022 12:22:09 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1noruT-000JTY-1O; Wed, 11 May 2022 19:22:09 +0000 Date: Thu, 12 May 2022 03:21:26 +0800 From: kernel test robot To: Maxime Ripard , Mike Turquette , Stephen Boyd , linux-clk@vger.kernel.org Cc: kbuild-all@lists.01.org, Jerome Brunet , Alexander Stein , Naresh Kamboju , Yassine Oudjana , Marek Szyprowski , Neil Armstrong , Dmitry Baryshkov , Tony Lindgren , Maxime Ripard Subject: Re: [PATCH v3 22/28] clk: Stop forwarding clk_rate_requests to the parent Message-ID: <202205120358.R563eKPN-lkp@intel.com> References: <20220511144249.354775-23-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220511144249.354775-23-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Maxime, I love your patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on linus/master v5.18-rc6 next-20220511] [cannot apply to anholt/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/clk-More-clock-rate-fixes-and-tests/20220511-224533 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: nios2-defconfig (https://download.01.org/0day-ci/archive/20220512/202205120358.R563eKPN-lkp@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/32af2a918274a92da86089672d5d7adba63dc0cf git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Maxime-Ripard/clk-More-clock-rate-fixes-and-tests/20220511-224533 git checkout 32af2a918274a92da86089672d5d7adba63dc0cf # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/clk/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/clk/clk.c: In function 'clk_hw_forward_rate_request': >> drivers/clk/clk.c:1502:45: warning: passing argument 2 of 'clk_core_forward_rate_req' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 1502 | clk_core_forward_rate_req(hw->core, old_req, | ^~~~~~~ drivers/clk/clk.c:568:59: note: expected 'struct clk_rate_request * const' but argument is of type 'const struct clk_rate_request *' 568 | struct clk_rate_request * const old_req, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ vim +1502 drivers/clk/clk.c 1481 1482 /** 1483 * clk_hw_forward_rate_request - Forwards a clk_rate_request to a clock's parent 1484 * @hw: the original clock that got the rate request 1485 * @old_req: the original clk_rate_request structure we want to forward 1486 * @parent: the clk we want to forward @old_req to 1487 * @req: the clk_rate_request structure we want to initialise 1488 * @parent_rate: The rate which is to be requested to @parent 1489 * 1490 * Initializes a clk_rate_request structure to submit to a clock parent 1491 * in __clk_determine_rate() or similar functions. 1492 */ 1493 void clk_hw_forward_rate_request(const struct clk_hw *hw, 1494 const struct clk_rate_request *old_req, 1495 const struct clk_hw *parent, 1496 struct clk_rate_request *req, 1497 unsigned long parent_rate) 1498 { 1499 if (WARN_ON(!hw || !old_req || !parent || !req)) 1500 return; 1501 > 1502 clk_core_forward_rate_req(hw->core, old_req, 1503 parent->core, req, 1504 parent_rate); 1505 } 1506 -- 0-DAY CI Kernel Test Service https://01.org/lkp