Re: [PATCH v2 06/20] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock

Krzysztof Kozlowski
2022-06-08T10:16:27Z

On 08/06/2022 11:56, Tomer Maimon wrote:
> Add binding for the Arbel BMC NPCM8XX Clock controller.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../bindings/clock/nuvoton,npcm845-clk.yaml | 63 +++++++++++++++++++
> .../dt-bindings/clock/nuvoton,npcm8xx-clock.h | 50 +++++++++++++++
> 2 files changed, 113 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> create mode 100644 include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
>
> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> new file mode 100644
> index 000000000000..e1f375716bc5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NPCM8XX Clock Controller Binding
> +
> +maintainers:
> + - Tomer Maimon <tmaimon77@gmail.com>
> +
> +description: |
> + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which
> + generates and supplies clocks to all modules within the BMC.
> +
> +properties:
> + compatible:
> + enum:
> + - nuvoton,npcm845-clk
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: 25M reference clock
> + - description: CPU reference clock
> + - description: MC reference clock
> +
> + clock-names:
> + items:
> + - const: refclk
> + - const: sysbypck
> + - const: mcbypck
> +

I asked what is the suffix about and you replied "ck"... ok, so let's
make clear. This should be:

items:
- const: ref
- const: sysbyp
- const: mcbyp

or something similar, without the same suffix all over.

> diff --git a/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h
> new file mode 100644
> index 000000000000..229915a254a5
> --- /dev/null
> +++ b/include/dt-bindings/clock/nuvoton,npcm8xx-clock.h

Same comment as before. No changes here...

Best regards,
Krzysztof