Re: [PATCH v2 12/20] dt-bindings: reset: npcm: Add support for NPCM8XX

Krzysztof Kozlowski
2022-06-10T09:56:03Z

On 10/06/2022 00:05, Tomer Maimon wrote:
> Hi Krzysztof,
>
> Sorry, but I thought the fix is only to add an explanation to the
> dt-binding file as was done in V2.
>
> The NPCM8XX binding is done in the same way as the NPCM7XX and both
> use the same reset driver and use the same reset method in upstreamed
> NPCM reset driver.
>
> Can you please explain again what you suggest to do?

If you want abstract IDs, they must be abstract, so not representing
hardware registers. Then they start at 1 and are incremented by 1.

Other option is to skip such IDs entirely and use register
offsets/addresses directly, like Arnd suggested in linked documents. I
think he expressed it clearly, so please read his answers which I linked
in previous discussion.

There is no single reason to store register addresses/values/offsets as
binding headers. These are not bindings.

Best regards,
Krzysztof