Re: [PATCH v11 0/5] PCI: qcom: Rework pipe_clk/pipe_clk_src handling

Dmitry Baryshkov
2022-07-07T17:09:19Z

On Thu, 7 Jul 2022 at 18:40, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Thu, Jul 07, 2022 at 05:03:48PM +0300, Dmitry Baryshkov wrote:
> > On 16/06/2022 21:21, Bjorn Helgaas wrote:
> > > On Wed, Jun 08, 2022 at 01:52:33PM +0300, Dmitry Baryshkov wrote:
> > > > PCIe pipe clk (and some other clocks) must be parked to the "safe"
> > > > source (bi_tcxo) when corresponding GDSC is turned off and on again.
> > > > Currently this is handcoded in the PCIe driver by reparenting the
> > > > gcc_pipe_N_clk_src clock.
>
> > > > Dmitry Baryshkov (5):
> > > > clk: qcom: regmap: add PHY clock source implementation
> > > > clk: qcom: gcc-sm8450: use new clk_regmap_phy_mux_ops for PCIe pipe
> > > > clocks
> > > > clk: qcom: gcc-sc7280: use new clk_regmap_phy_mux_ops for PCIe pipe
> > > > clocks
> > > > PCI: qcom: Remove unnecessary pipe_clk handling
> > > > PCI: qcom: Drop manual pipe_clk_src handling
> > > >
> > > >
> > > > Dmitry Baryshkov (5):
> > > > clk: qcom: regmap: add PHY clock source implementation
> > > > clk: qcom: gcc-sm8450: use new clk_regmap_phy_mux_ops for PCIe pipe
> > > > clocks
> > > > clk: qcom: gcc-sc7280: use new clk_regmap_phy_mux_ops for PCIe pipe
> > > > clocks
> > > > PCI: qcom: Remove unnecessary pipe_clk handling
> > > > PCI: qcom: Drop manual pipe_clk_src handling
> > > >
> > > > drivers/clk/qcom/Makefile | 1 +
> > > > drivers/clk/qcom/clk-regmap-phy-mux.c | 62 ++++++++++++++++++++
> > > > drivers/clk/qcom/clk-regmap-phy-mux.h | 33 +++++++++++
> > > > drivers/clk/qcom/gcc-sc7280.c | 49 +++++-----------
> > > > drivers/clk/qcom/gcc-sm8450.c | 49 +++++-----------
> > > > drivers/pci/controller/dwc/pcie-qcom.c | 81 +-------------------------
> > > > 6 files changed, 127 insertions(+), 148 deletions(-)
> > > > create mode 100644 drivers/clk/qcom/clk-regmap-phy-mux.c
> > > > create mode 100644 drivers/clk/qcom/clk-regmap-phy-mux.h
> > >
> > > I applied this to pci/ctrl/qcom for v5.20, thanks!
> > >
> > > Clock folks (Bjorn A, Andy, Michael, Stephen), I assume you're OK with
> > > these being merged via the PCI tree. Let me know if you prefer
> > > anything different.
> >
> > I noticed that this patchset is not a part of linux-next. Is it still
> > pending to be merged in 5.20?
>
> It's still pending. I currently have three separate qcom-related
> branches that need to be reconciled before I put them in -next.

Ok, thank you for the explanation. Please excuse my worries.

--
With best wishes
Dmitry