From: Stephen Boyd <sboyd@kernel.org>
To: Liang He <windhl@126.com>,
jonathanh@nvidia.com, pdeschrijver@nvidia.com,
pgaikwad@nvidia.com, thierry.reding@gmail.com
Cc: windhl@126.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drivers: clk: Add missing of_node_put()
Date: Thu, 16 Jun 2022 17:09:11 -0700 [thread overview]
Message-ID: <20220617000913.24A4CC34114@smtp.kernel.org> (raw)
In-Reply-To: <20220616125409.3986745-1-windhl@126.com>
Quoting Liang He (2022-06-16 05:54:09)
> In these clk-related drivers' xxx_init() funcitons, of_find_matching_node()
> will return a node pointer with refcount incremented. We should use
> of_node_put() in fail path or when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
> changelog:
>
> v3: merge clk 'missing of_node_put()' patches into one commit.
> v2: use Liang He as real name for S-o-b.
> v1: fix the missing of_node_put().
>
>
> drivers/clk/clk-nomadik.c | 5 ++++-
> drivers/clk/tegra/clk-tegra124.c | 1 +
> drivers/clk/tegra/clk-tegra30.c | 1 +
Please split into a tegra patch and a nomadik patch.
next prev parent reply other threads:[~2022-06-17 0:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 12:54 [PATCH v3] drivers: clk: Add missing of_node_put() Liang He
2022-06-17 0:09 ` Stephen Boyd [this message]
2022-06-17 1:20 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220617000913.24A4CC34114@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox