From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64A1C43334 for ; Wed, 29 Jun 2022 03:24:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230470AbiF2DYu (ORCPT ); Tue, 28 Jun 2022 23:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbiF2DYT (ORCPT ); Tue, 28 Jun 2022 23:24:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0609BC08; Tue, 28 Jun 2022 20:24:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 94655B81BAF; Wed, 29 Jun 2022 03:24:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC686C341C6; Wed, 29 Jun 2022 03:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656473056; bh=hEKpqsCTCBYl6X3gx6o4CGg4SOmuRDZ3EoHxt9IO4QA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IhmRobJSTIP86pLtSRAiaGG98BmiqQqGSXRMjhzDITCuEpkAwp5eCrogCu1DVC4Ih e50Vdb4galVkGeIOYFbI/eDIWJ/XXq1dFSQgyj2Gl8ZeRvKdg4kmOS22Y2QsjcQm0g UgGPMw7F2ZXVKKY8j16xQvZ6UDXgfrm+9kLh/kgRp2tXl2gbss9tg1MB3RC8A5gN60 fqQjfkPXY+CIhOvcJcl2OIhwnq2PmJBxqIg8njS7vTeFcyC+OjTQRIPUoxiChWc2PA HOM0mvHoXbCDSZYWR9j9n71AS5hGnEjF+whcOpjJX03ScJmD8tMjAbk8C3uOylkekO 0E5mkTI/KcKKQ== Date: Tue, 28 Jun 2022 20:24:14 -0700 From: Jakub Kicinski To: Jonathan Lemon Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Vadim Fedorenko , Aya Levin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [RFC PATCH v2 3/3] ptp_ocp: implement DPLL ops Message-ID: <20220628202414.02ac8fd1@kernel.org> In-Reply-To: <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com> References: <20220626192444.29321-1-vfedorenko@novek.ru> <20220626192444.29321-4-vfedorenko@novek.ru> <20220627193436.3wjunjqqtx7dtqm6@bsd-mbp.dhcp.thefacebook.com> <7c2fa2e9-6353-5472-75c8-b3ffe403f0f3@novek.ru> <20220628191124.qvto5tyfe63htxxr@bsd-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 28 Jun 2022 12:11:24 -0700 Jonathan Lemon wrote: > > > 80-column limit (here and throughout the file) > > > > I thought this rule was relaxed up to 100-columns? > > Only in exceptional cases, IIRC. checkpatch complains too. Yup, for networking I still prefer 80 chars. My field of vision is narrow. > > > 80 cols, and this should be done before ptp_ocp_complete() > > > Also, should 'goto out', not return 0 and leak resources. > > > > I don't think we have to go with error path. Driver itself can work without > > DPLL device registered, there is no hard dependency. The DPLL device will > > not be registered and HW could not be configured/monitored via netlink, but > > could still be usable. > > Not sure I agree with that - the DPLL device is selected in Kconfig, so > users would expect to have it present. I think it makes more sense to > fail if it cannot be allocated. +1