Re: [PATCH v2 03/12] reset: add polarfire soc reset support

Conor.Dooley
2022-07-18T15:44:57Z

On 18/07/2022 16:42, Philipp Zabel wrote:
> Hi Conor,
>
> On Mo, 2022-07-18 at 11:34 +0000, Conor.Dooley@microchip.com wrote:
> [...]
>>> +config RESET_POLARFIRE_SOC
>>> + bool "Microchip PolarFire SoC (MPFS) Reset Driver"
>>> + depends on AUXILIARY_BUS && MCHP_CLK_MPFS
>>> + default MCHP_CLK_MPFS
>>> + help
>>> + This driver supports peripheral reset for the Microchip PolarFire SoC
>>> +
>
> Please sort alphabetically by config option.
>
>>>   config RESET_MESON
>>>    tristate "Meson Reset Driver"
>>>    depends on ARCH_MESON || COMPILE_TEST
>>> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
>>> index a80a9c4008a7..5fac3a753858 100644
>>> --- a/drivers/reset/Makefile
>>> +++ b/drivers/reset/Makefile
>>> @@ -17,6 +17,7 @@ obj-$(CONFIG_RESET_K210) += reset-k210.o
>>>   obj-$(CONFIG_RESET_LANTIQ) += reset-lantiq.o
>>>   obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
>>>   obj-$(CONFIG_RESET_MCHP_SPARX5) += reset-microchip-sparx5.o
>>> +obj-$(CONFIG_RESET_POLARFIRE_SOC) += reset-mpfs.o
>
> Same here. Otherwise,

That's weird - thought I had done!
I'll fix it for v3.

>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> and
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

Thanks Philipp.
Conor

>
> to merge this together with the other patches.
>
> regards
> Philipp