Re: [PATCH v6 02/28] clk: bcm: rpi: Add a function to retrieve the maximum

kernel test robot
2022-07-16T04:55:04Z

Hi Maxime,

I love your patch! Perhaps something to improve:

[auto build test WARNING on clk/clk-next]
[also build test WARNING on drm-misc/drm-misc-next linus/master v5.19-rc6 next-20220715]
[cannot apply to anholt/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/clk-More-clock-rate-fixes-and-tests/20220711-232652
base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: arc-randconfig-r043-20220715 (https://download.01.org/0day-ci/archive/20220716/202207161221.vqfztQIZ-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/461ea72e08a9200c6874414e709885d73fe0cfb9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Maxime-Ripard/clk-More-clock-rate-fixes-and-tests/20220711-232652
git checkout 461ea72e08a9200c6874414e709885d73fe0cfb9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/clk/bcm/ drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/clk/bcm/clk-raspberrypi.c:257:15: warning: no previous prototype for 'rpi_firmware_clk_get_max_rate' [-Wmissing-prototypes]
257 | unsigned long rpi_firmware_clk_get_max_rate(struct clk *clk)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/rpi_firmware_clk_get_max_rate +257 drivers/clk/bcm/clk-raspberrypi.c

256
> 257 unsigned long rpi_firmware_clk_get_max_rate(struct clk *clk)
258 {
259 const struct raspberrypi_clk_data *data;
260 struct raspberrypi_clk *rpi;
261 struct clk_hw *hw;
262 u32 max_rate;
263 int ret;
264
265 if (!clk)
266 return 0;
267
268 hw = __clk_get_hw(clk);
269 if (!hw)
270 return 0;
271
272 data = clk_hw_to_data(hw);
273 rpi = data->rpi;
274 ret = raspberrypi_clock_property(rpi->firmware, data,
275 RPI_FIRMWARE_GET_MAX_CLOCK_RATE,
276 &max_rate);
277 if (ret)
278 return 0;
279
280 return max_rate;
281 }
282 EXPORT_SYMBOL_GPL(rpi_firmware_clk_get_max_rate);
283

--
0-DAY CI Kernel Test Service