From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794C5C43334 for ; Mon, 18 Jul 2022 22:19:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233858AbiGRWTF (ORCPT ); Mon, 18 Jul 2022 18:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbiGRWTE (ORCPT ); Mon, 18 Jul 2022 18:19:04 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461E05F50; Mon, 18 Jul 2022 15:19:04 -0700 (PDT) Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 7A8A366019F3; Mon, 18 Jul 2022 23:19:01 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658182742; bh=cpVbYxStkk0TBWfh3vWvgvkINPgtVFCpknaqG3L5bMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dse5PnL5X29rke4WJf6H2vO5GuMVfPClG3lZkbvKx+BXigza2knJVk+8uxcFG3+Nm DVDe2juLAnNjXr1s6JUVsg9z5EEdXAKQUtZ6trhIWlXE1fp1zrdcZsAP44BN7egHl3 F2NYsMgwxYObJ1/VHsHJ6j4do6ireEAM3+oppRVwslGpf3I028n+CgST8QYFsIgT0O 08p7peYZDEFsM7fpsj2oES2+1v/WtWDQIryOsgtzoCSOR+MMczJJuDSzYujjHZwz++ vDiQCbeRxkUe9pi1eIc06YdkLxAQBPzSiCcn8w/iJNk92uorvbIMKJbpbXf9HBObg0 5qUSCxAjMXxnQ== Date: Mon, 18 Jul 2022 18:18:57 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno Subject: Re: [PATCH v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops Message-ID: <20220718221857.7vgmsgqxozytkofa@notapiano> References: <20220713082111.2233016-1-wenst@chromium.org> <20220713082111.2233016-2-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220713082111.2233016-2-wenst@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Jul 13, 2022 at 04:21:10PM +0800, Chen-Yu Tsai wrote: > In the previous commits that added CLK_OPS_PARENT_ENABLE, support for > this flag was only added to rate change operations (rate setting and > reparent) and disabling unused subtree. It was not added to the > clock gate related operations. Any hardware driver that needs it for > these operations will either see bogus results, or worse, hang. > > This has been seen on MT8192 and MT8195, where the imp_ii2_* clk > drivers set this, but dumping debugfs clk_summary would cause it > to hang. > > Fixes: fc8726a2c021 ("clk: core: support clocks which requires parents enable (part 2)") > Fixes: a4b3518d146f ("clk: core: support clocks which requires parents enable (part 1)") > Signed-off-by: Chen-Yu Tsai Reviewed-by: Nícolas F. R. A. Prado Tested-by: Nícolas F. R. A. Prado Tested that MT8192 no longer hangs when dumping clk_summary. Thanks, Nícolas