From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6585C19F29 for ; Thu, 28 Jul 2022 00:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234253AbiG1Ab7 (ORCPT ); Wed, 27 Jul 2022 20:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiG1Ab6 (ORCPT ); Wed, 27 Jul 2022 20:31:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81EE54CA0; Wed, 27 Jul 2022 17:31:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 75B23B8229F; Thu, 28 Jul 2022 00:31:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22D28C433D6; Thu, 28 Jul 2022 00:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658968315; bh=cgMax9nf9qW48JMtAkUoIyip26M7Bpa8V5h47PbKfC4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nlqaAET4ci75hpEpVFTfRPIEF2htScl2LXIAlqXintsUaUKetcCiPAzb42chVmnkB wKr9EwczFt7JxVVho5QiYakPC+GtoRtP4t0rfUVwGo9Fslccl0m+4xx7uQrCsgmCTm DO7IySLE7/4lrN2Wbug+uNmq4hEj2qUCKYShnJduTcyRX+nB26mLun1a4MxFjOqyJ1 f2wI2hMWzsu0AaZVl7XYyzu8ulkz9VwMj5klckTi/1Y0zHSSkpKf/rEdKtDtWEXpkd VpwhUErr0IIXtuOyfLAJvhkyLkJGvvPVMm6yRSH/RtCPQnAFIrj9KScMWnH2Stkk5W Rj4PZYLvujSxA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220714203822.186448-1-marijn.suijten@somainline.org> References: <20220714203822.186448-1-marijn.suijten@somainline.org> Subject: Re: [PATCH] clk: qcom: gcc-sdm660: Use floor ops for SDCC1 clock From: Stephen Boyd Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Marijn Suijten , Andy Gross , Bjorn Andersson , Michael Turquette , Taniya Das , Rob Herring , Craig Tatlor , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Marijn Suijten , phone-devel@vger.kernel.org Date: Wed, 27 Jul 2022 17:31:53 -0700 User-Agent: alot/0.10 Message-Id: <20220728003155.22D28C433D6@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Marijn Suijten (2022-07-14 13:38:22) > In commit 3f905469c8ce ("clk: qcom: gcc: Use floor ops for SDCC clocks") > floor ops were applied to SDCC2 only, but flooring is also required on > the SDCC1 apps clock which is used by the eMMC card on Sony's Nile > platform, and otherwise result in the typicial "Card appears > overclocked" warnings observed on many other platforms before: >=20 > mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz > mmc0: Card appears overclocked; req 52000000 Hz, actual 100000000 Hz > mmc0: Card appears overclocked; req 104000000 Hz, actual 192000000 Hz >=20 > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver= for SDM660") > Signed-off-by: Marijn Suijten > --- Reviewed-by: Stephen Boyd