From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24036C32771 for ; Fri, 19 Aug 2022 21:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbiHSVez (ORCPT ); Fri, 19 Aug 2022 17:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbiHSVey (ORCPT ); Fri, 19 Aug 2022 17:34:54 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614D510E970 for ; Fri, 19 Aug 2022 14:34:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D14B9CE2784 for ; Fri, 19 Aug 2022 21:34:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB89C433D6; Fri, 19 Aug 2022 21:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660944890; bh=jEifeMvcVcmUL3AvDcd/wNV8VBXPnemd0/AWGv67n00=; h=In-Reply-To:References:Subject:From:To:Date:From; b=ORnzM8sF19lyi/0MSqydQmLSlFx8hg/Cdo9Ej4pxdMl4P0eo3Vh6GS61ukCQU1nrJ Kk365lv4r9SOHUSKDwMQEA4Ea49BvPu0ch5LMTXXyebXSzqJw5Bi2CcnP43gH3F0Sh oudSYDgLT4qFFDNQ3Mv3DR2+6w5nBNh3HUnAEEKU3F5bMMXYQUI3ftLmknFJGT9JBd zLZKUuTguEqK3L7xIMJTqDKXiKEhgWMMua8ziHn6VsItadDofFCUKzwdqFc8ajM4dz TE0cTXNO/PdCm/R8Sj+EnvSpmIrLHsjZHVHHBJJzcHAnz9ULGu7pKk06EwspP1rfwW xDYwWmrJjVDFg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220628142416.169808-1-windhl@126.com> References: <20220628142416.169808-1-windhl@126.com> Subject: Re: [PATCH v2] clk: st: Hold reference returned by of_get_parent() From: Stephen Boyd To: linux-clk@vger.kernel.org, mturquette@baylibre.com, windhl@126.com Date: Fri, 19 Aug 2022 14:34:48 -0700 User-Agent: alot/0.10 Message-Id: <20220819213450.1DB89C433D6@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Liang He (2022-06-28 07:24:15) > We should hold the reference returned by of_get_parent() and use it > to call of_node_put() for refcount balance. >=20 > Fixes: 3efe64ef5186 ("clk: st: clkgen-fsyn: search reg within node or par= ent") > Fixes: 810251b0d36a ("clk: st: clkgen-mux: search reg within node or pare= nt") >=20 > Signed-off-by: Liang He > --- Applied to clk-next