From: Bjorn Andersson <andersson@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Taniya Das <tdas@codeaurora.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Caleb Connolly <caleb@connolly.tech>,
Joel Selvaraj <jo@jsfamily.in>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: clock: gcc-sdm845: add sdm670 global clocks
Date: Mon, 12 Sep 2022 22:47:53 -0500 [thread overview]
Message-ID: <20220913034753.gmdcnm54x5lw7bxc@builder.lan> (raw)
In-Reply-To: <20220908231224.209020-2-mailingradian@gmail.com>
On Thu, Sep 08, 2022 at 07:12:22PM -0400, Richard Acayan wrote:
[..]
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,gcc-sdm670
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source
> + clock-names:
> + items:
> + - const: bi_tcxo
> + - const: bi_tcxo_ao
> + - const: sleep_clk
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,gcc-sdm845
> + then:
> + properties:
> + clocks:
> + items:
> + - description: Board XO source
> + - description: Board active XO source
> + - description: Sleep clock source
> + - description: PCIE 0 Pipe clock source
> + - description: PCIE 1 Pipe clock source
> + clock-names:
> + items:
> + - const: bi_tcxo
> + - const: bi_tcxo_ao
> + - const: sleep_clk
> + - const: pcie_0_pipe_clk
> + - const: pcie_1_pipe_clk
> +
Series looks good to me, but linux-next has 0f71ae945730 ("dt-bindings:
clk: qcom,gcc-*: use qcom,gcc.yaml") which conflicts with this addition.
Can you please rebase on top of linux-next, retest and submit a new
version?
Thanks,
Bjorn
next prev parent reply other threads:[~2022-09-13 3:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 23:12 [PATCH v3 0/3] SDM670 Global Clocks Richard Acayan
2022-09-08 23:12 ` [PATCH v3 1/3] dt-bindings: clock: gcc-sdm845: add sdm670 global clocks Richard Acayan
2022-09-13 3:47 ` Bjorn Andersson [this message]
2022-09-08 23:12 ` [PATCH v3 2/3] clk: qcom: gcc-sdm845: use device tree match data Richard Acayan
2022-09-08 23:12 ` [PATCH v3 3/3] clk: qcom: gcc-sdm845: add sdm670 global clock data Richard Acayan
2022-09-09 7:48 ` Krzysztof Kozlowski
2022-09-15 3:36 ` [PATCH v3 0/3] SDM670 Global Clocks Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220913034753.gmdcnm54x5lw7bxc@builder.lan \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=devicetree@vger.kernel.org \
--cc=jo@jsfamily.in \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox