Re: [PATCH 01/11] dt-bindings: clock: split qcom,gcc-msm8974,-msm8226 to the separate file

Krzysztof Kozlowski
2022-09-28T17:11:05Z

On 28/09/2022 16:59, Dmitry Baryshkov wrote:
> Move schema for the GCC on MSM8974 and MSM8226 platforms to a separate
> file to be able to define device-specific clock properties.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> .../bindings/clock/qcom,gcc-msm8974.yaml | 65 +++++++++++++++++++
> .../bindings/clock/qcom,gcc-other.yaml | 9 +--
> 2 files changed, 66 insertions(+), 8 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-msm8974.yaml

Thank you for your patch. There is something to discuss/improve.

>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8974.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8974.yaml
> new file mode 100644
> index 000000000000..72e8f54d0e0e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8974.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0-only

Dual license

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,gcc-msm8974.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Global Clock & Reset Controller Binding for MSM8226 and
> + MSM8974, including Pro variants
> +
> +maintainers:
> + - Stephen Boyd <sboyd@kernel.org>
> + - Taniya Das <tdas@codeaurora.org>

That's not valid email anymore, I think.

> +
> +description: |
> + Qualcomm global clock control module which supports the clocks, resets and
> + power domains on SDM630, SDM636 and SDM660

The model numbers need updates.

> +
> + See also:
> + - dt-bindings/clock/qcom,gcc-msm8974.h (qcom,gcc-msm8226 and qcom,gcc-msm8974)
> + - dt-bindings/reset/qcom,gcc-msm8974.h (qcom,gcc-msm8226 and qcom,gcc-msm8974)
> +
> +$ref: qcom,gcc.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,gcc-msm8226
> + - qcom,gcc-msm8974
> + - qcom,gcc-msm8974pro
> + - qcom,gcc-msm8974pro-ac
> +
> + clocks:
> + items:
> + - description: XO source
> + - description: Sleep clock source
> +
> + clock-names:
> + items:
> + - const: xo
> + - const: sleep_clk
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +unevaluatedProperties: false
> +
> +examples:
> + # Example for GCC for SDM660:

Maybe skip the comment?

> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + clock-controller@fc400000 {
> + compatible = "qcom,gcc-msm8974";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + reg = <0x00100000 0x94000>;

reg goes usually after compatible.

> +
> + clock-names = "xo", "sleep_clk";
> + clocks = <&xo_board>,
> + <&sleep_clk>;
> + };
> +...

Best regards,
Krzysztof