From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE0EC4332F for ; Tue, 18 Oct 2022 07:32:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbiJRHcK (ORCPT ); Tue, 18 Oct 2022 03:32:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbiJRHcI (ORCPT ); Tue, 18 Oct 2022 03:32:08 -0400 Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0879B1FCE2; Tue, 18 Oct 2022 00:32:06 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 757C6580155; Tue, 18 Oct 2022 03:32:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 18 Oct 2022 03:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666078324; x= 1666085524; bh=x8Kpf7Ca60+0626HPD6lKqagYPSPMGNpcqJHOsdVPg4=; b=c qk9JAMkhFYmJG+cxMVtlFC29ZG0OibbkpFqL8SZr4bKMbcs67y+kWVzwFJaxtngM lT72P28/DfFs69Srr9tJ02RUQS4XuaAP3kFB6kDCYWEI9bGIQ2Aw11EXoFVM31YJ swbwgfAI4nnwImpycgFBT0/Tf7iJ/5pwU5dzxFKF3sUOCiJ6EdqmkqH8HeS3+et/ 0/d9pOI8v1he405a00A5/dUCF4HP0rQFLrI8bj7daewvXohydhZzpixy1IW/H+ev ZffparVVjMse56F5unfod4bqNCdbGFIsc2GxM+T1m8Zkyrd3G6ADqPfYBq1kPe5G GtVRTXe2DnITFTQxeHH5w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666078324; x= 1666085524; bh=x8Kpf7Ca60+0626HPD6lKqagYPSPMGNpcqJHOsdVPg4=; b=d +yWVvqdRVhyutCeiw5LO0/K/MTbO/8W+XVxp/G+SDseiiq7JlVhJiyCUMSZMLLxR hCkvWqW7tLBSZvUbTUvk+xBJyUKz68bgAdSmgHSiFEWOufQuiTnvzunCdaxcYann 5s6xSI9vUWeSO+1LC+uU63Ke35foc6dzOtMWDwGrBLK6lHId140UOz/e35uOeaxD EUDJfVJ7GECZQLMWdJ8cicQZjK0IsjHedu9QHuq8rna2B6LvqoYXTnxLNHxhUA4R jCTdceXycqdWFVkmr7j0zkRBNRTA3yDKwEenjrjEL0wSzf2PqX7ZVMlK6H5GrTDB zea7VndIybeSO2R/YEJ/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeltddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgr gihimhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtf frrghtthgvrhhnpeetgfelgefggeekkefggfeludeiudffjeffgeevveekjedukedtudeu teefteefgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Oct 2022 03:32:02 -0400 (EDT) Date: Tue, 18 Oct 2022 09:32:01 +0200 From: Maxime Ripard To: Florian Fainelli Cc: Michael Turquette , Emma Anholt , Stephen Boyd , Ray Jui , Scott Branden , Broadcom internal kernel review list , Daniel Vetter , David Airlie , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Dom Cobley , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 1/7] firmware: raspberrypi: Introduce rpi_firmware_find_node() Message-ID: <20221018073201.hcptjdalvn47n25t@houat> References: <20220815-rpi-fix-4k-60-v3-0-fc56729d11fe@cerno.tech> <20220815-rpi-fix-4k-60-v3-1-fc56729d11fe@cerno.tech> <890f6ab1-f6aa-76c8-01e8-f7233143d7ec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <890f6ab1-f6aa-76c8-01e8-f7233143d7ec@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Florian On Fri, Oct 14, 2022 at 12:43:38PM -0700, Florian Fainelli wrote: > On 10/13/22 02:13, Maxime Ripard wrote: > > A significant number of RaspberryPi drivers using the firmware don't > > have a phandle to it, so end up scanning the device tree to find a node > > with the firmware compatible. > >=20 > > That code is duplicated everywhere, so let's introduce a helper instead. > >=20 > > Signed-off-by: Maxime Ripard > > --- > > drivers/firmware/raspberrypi.c | 7 +++++++ > > include/soc/bcm2835/raspberrypi-firmware.h | 7 +++++++ > > 2 files changed, 14 insertions(+) > >=20 > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberr= ypi.c > > index 4b8978b254f9..b916e1e171f8 100644 > > --- a/drivers/firmware/raspberrypi.c > > +++ b/drivers/firmware/raspberrypi.c > > @@ -311,6 +311,13 @@ static int rpi_firmware_remove(struct platform_dev= ice *pdev) > > return 0; > > } > > +static const struct of_device_id rpi_firmware_of_match[]; >=20 > This shadows the same variable that is used later for matching the firmwa= re > driver and probe it as a platform_driver, what am I missing here? I'm not shadowing the variable, but it's a forward-declaration. Maxime