From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D507AC433FE for ; Tue, 18 Oct 2022 14:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229535AbiJROYN convert rfc822-to-8bit (ORCPT ); Tue, 18 Oct 2022 10:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbiJROYM (ORCPT ); Tue, 18 Oct 2022 10:24:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2BEF1E715; Tue, 18 Oct 2022 07:24:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 693A1B81BE1; Tue, 18 Oct 2022 14:24:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C117C433C1; Tue, 18 Oct 2022 14:24:08 +0000 (UTC) Date: Tue, 18 Oct 2022 10:24:09 -0400 From: Steven Rostedt To: Maxime Ripard Cc: Stephen Boyd , Michael Turquette , Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/2] clk: Add trace events for rate requests Message-ID: <20221018102409.594be3e4@gandalf.local.home> In-Reply-To: <20221018-clk-rate-request-tracing-v1-2-6f3aa0b0b9de@cerno.tech> References: <20221018-clk-rate-request-tracing-v1-0-6f3aa0b0b9de@cerno.tech> <20221018-clk-rate-request-tracing-v1-2-6f3aa0b0b9de@cerno.tech> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 18 Oct 2022 15:56:42 +0200 Maxime Ripard wrote: > It is currently fairly difficult to follow what clk_rate_request are > issued, and how they have been modified once done. > > Indeed, there's multiple paths that can be taken, some functions are > recursive and will just forward the request to its parent, etc. > > Adding a lot of debug prints is just not very convenient, so let's add > trace events for the clock requests, one before they are submitted and > one after they are returned. > > That way we can simply toggle the tracing on without modifying the > kernel code and without affecting performances or the kernel logs too > much. > > Signed-off-by: Maxime Ripard >From a tracing point of view: Reviewed-by: Steven Rostedt (Google) -- Steve > --- > drivers/clk/clk.c | 31 +++++++++++++++++++++++++++++++ > include/trace/events/clk.h | 43 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 74 insertions(+)