From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2824BFA3740 for ; Thu, 27 Oct 2022 21:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236297AbiJ0Vl5 (ORCPT ); Thu, 27 Oct 2022 17:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236117AbiJ0Vly (ORCPT ); Thu, 27 Oct 2022 17:41:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E7CB4B4A0; Thu, 27 Oct 2022 14:41:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E82B3B827DE; Thu, 27 Oct 2022 21:41:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F112C433D6; Thu, 27 Oct 2022 21:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666906911; bh=+bqMYfhBoMQBNclMwiXInuF4126VdbEDPwSYcMlTatk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=CJRlxu66YR1gJs+s/NRcf9oKssdDMmsNjr8UoEhMmO0BXaC5th/zLePkc9dB6Kfk1 x6OmBiPkcO1KJDdZsxscaN8ZlqWvZdoHZbgds/k2Bvmgj9Dl3Yb9Cl946pyKrj2rat hJHXHbwRo0MRo9ApgPkb4JO8xANJvDN8P5wR7cSjTWZEe5PmONuVZ7Y1GuEt0HcG6e lbK6VL4KcBv7hSwPl2IRLroc1paBs4BmP9IMRzPc/BZ3xeTBHlOLDamhgj8NTRcuhL jiHOk3G3pyDA5u5k6bnWMVP2zIMEJ+P9TxPvw7uzqzOX0iica03IJcc2g0VXYzlm1r a/PEVvzF7+4bg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <5e55012567da74870e1fb2edc2dc513b5821e523.1666801017.git.daniel@makrotopia.org> References: <9bde77be-f4ec-11e7-e645-7c4465bcf6db@collabora.com> <5e55012567da74870e1fb2edc2dc513b5821e523.1666801017.git.daniel@makrotopia.org> Subject: Re: [PATCH v2] clk: mediatek: fix dependency of MT7986 ADC clocks From: Stephen Boyd Cc: Sam Shih , Miles Chen , AngeloGioacchino Del Regno , Chen-Yu Tsai To: Daniel Golle , Matthias Brugger , Michael Turquette , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Date: Thu, 27 Oct 2022 14:41:49 -0700 User-Agent: alot/0.10 Message-Id: <20221027214151.7F112C433D6@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Daniel Golle (2022-10-26 09:18:07) > It seems like CLK_INFRA_ADC_FRC_CK always need to be enabled for > CLK_INFRA_ADC_26M_CK to work. Instead of adding this dependency to the > mtk-thermal and mt6577_auxadc drivers, add dependency to the clock > driver clk-mt7986-infracfg.c. Is this a cleanup patch? Or a pre-requisite for thermal and auxadc drivers? I don't understand the priority of this patch. Should I apply it to fix a regression?