From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87AC1C4332F for ; Fri, 4 Nov 2022 19:19:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiKDTTX (ORCPT ); Fri, 4 Nov 2022 15:19:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiKDTTW (ORCPT ); Fri, 4 Nov 2022 15:19:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD0FE1EAEC; Fri, 4 Nov 2022 12:19:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 465B8B82C15; Fri, 4 Nov 2022 19:19:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5A5BC433C1; Fri, 4 Nov 2022 19:19:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667589559; bh=0RirpirjsLnaVPx1PgTePlEUSgmd94GAbbiGvTlUvaA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=THsipqpFeDHQzK5Wjt0lROYi2TKljfvb3U5POh+Arg4GREwG3NKh+6kcpkbj81GuS TM5FVc5RUqBjU8ZhFNCceMs/n/Tt5XiDeOlCvRK4dqounnFZ/otTfRuLdIY0oJBMPJ VJJHJpSni/3lcdj2hPn7di6aN/+JfoT81cZtLK3LVSkBrbJNEfBL/D/Pr57Y9+iUV7 7jXKrit0hfndiSZ330VkMIHlAKEirLgzVBpJWPrpqe9OJQIjJoRqeY3WaFXFJw8nUW mQZI/VVWix2tpzwCjFk6Me5NpMg4slyzkCoE8lwGMBgZk3n4HtbT2PvEPQev50mF8y 2idMn/RQUSeWA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221103183030.3594899-1-swboyd@chromium.org> References: <20221103183030.3594899-1-swboyd@chromium.org> Subject: Re: [PATCH v3] clk: qcom: gdsc: Remove direct runtime PM calls From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Johan Hovold , Ulf Hansson , Taniya Das , Satya Priya , Douglas Anderson , Matthias Kaehlcke To: Michael Turquette , Stephen Boyd Date: Fri, 04 Nov 2022 12:19:16 -0700 User-Agent: alot/0.10 Message-Id: <20221104191918.D5A5BC433C1@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Stephen Boyd (2022-11-03 11:30:30) > We shouldn't be calling runtime PM APIs from within the genpd > enable/disable path for a couple reasons. >=20 > First, this causes an AA lockdep splat[1] because genpd can call into > genpd code again while holding the genpd lock. >=20 > WARNING: possible recursive locking detected > 5.19.0-rc2-lockdep+ #7 Not tainted Applied to clk-fixes