Re: [PATCH v2 05/23] clk: mediatek: clk-mtk: Propagate struct device for composites

Markus Schneider-Pargmann
2023-01-06T17:09:57Z

Hi,

On Fri, Dec 23, 2022 at 10:42:41AM +0100, AngeloGioacchino Del Regno wrote:
> Like done for cpumux clocks, propagate struct device for composite
> clocks registered through clk-mtk helpers to be able to get runtime
> pm support for MTK clocks.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/clk/mediatek/clk-mt2701.c | 4 ++--
> drivers/clk/mediatek/clk-mt2712.c | 4 ++--
> drivers/clk/mediatek/clk-mt6779.c | 4 ++--
> drivers/clk/mediatek/clk-mt6795-pericfg.c | 2 +-
> drivers/clk/mediatek/clk-mt6795-topckgen.c | 2 +-
> drivers/clk/mediatek/clk-mt6797.c | 2 +-
> drivers/clk/mediatek/clk-mt7622.c | 5 +++--
> drivers/clk/mediatek/clk-mt7629.c | 4 ++--
> drivers/clk/mediatek/clk-mt8135.c | 4 ++--
> drivers/clk/mediatek/clk-mt8167.c | 4 ++--
> drivers/clk/mediatek/clk-mt8173.c | 4 ++--
> drivers/clk/mediatek/clk-mt8183.c | 6 +++---
> drivers/clk/mediatek/clk-mt8186-mcu.c | 2 +-
> drivers/clk/mediatek/clk-mt8186-topckgen.c | 4 ++--
> drivers/clk/mediatek/clk-mt8192.c | 4 ++--
> drivers/clk/mediatek/clk-mt8195-topckgen.c | 2 +-
> drivers/clk/mediatek/clk-mt8365.c | 5 +++--
> drivers/clk/mediatek/clk-mt8516.c | 4 ++--
> drivers/clk/mediatek/clk-mtk.c | 9 +++++----
> drivers/clk/mediatek/clk-mtk.h | 3 ++-
> 20 files changed, 41 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/clk/mediatek/clk-mt2701.c b/drivers/clk/mediatek/clk-mt2701.c
> index dcae25778817..bd62acb5d697 100644
> --- a/drivers/clk/mediatek/clk-mt2701.c
> +++ b/drivers/clk/mediatek/clk-mt2701.c
> @@ -684,7 +684,7 @@ static int mtk_topckgen_init(struct platform_device *pdev)
> clk_data);
>
> mtk_clk_register_composites(top_muxes, ARRAY_SIZE(top_muxes),
> - base, &mt2701_clk_lock, clk_data);
> + base, &mt2701_clk_lock, clk_data, &pdev->dev);

The patch looks good in general, just a few nitpicks like this where you
could adjust the indentation to the open parenthesis.
'checkpatch.pl --strict' will show you all the locations where it is not
correct here and in other patches.

Best,
Markus