Re: [PATCH v2 09/23] clk: mediatek: mt8173: Remove mtk_clk_enable_critical()

Chen-Yu Tsai
2023-01-11T02:27:27Z

On Tue, Jan 10, 2023 at 01:32:34PM +0100, AngeloGioacchino Del Regno wrote:
> Il 30/12/22 05:58, Chen-Yu Tsai ha scritto:
> > On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com> wrote:
> > >
> > > The entire point of mtk_clk_enable_critical() is to raise the refcount
> > > of some clocks so that they won't be turned off during runtime, but
> > > this is the same as what the CLK_IS_CRITICAL flag does.
> > >
> > > Set CLK_IS_CRITICAL on all of the critical clocks and remove the
> > > aforementioned function as a cleanup.
> > >
> > > No functional changes.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >
> >
> > Looks good to me,
> >
> > Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> >
> > However, if you move this patch before the previous one ...
> >
> > > ---
> > > drivers/clk/mediatek/clk-mt8173.c | 41 ++++++++++++-------------------
> > > 1 file changed, 16 insertions(+), 25 deletions(-)
> > >
> > > diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> > > index 70cdc0719658..02231f8ba6d9 100644
> > > --- a/drivers/clk/mediatek/clk-mt8173.c
> > > +++ b/drivers/clk/mediatek/clk-mt8173.c
>
> > > @@ -846,23 +852,8 @@ static const struct mtk_clk_rst_desc clk_rst_desc[] = {
> > > }
> > > };
> > >
> > > -static struct clk_hw_onecell_data *mt8173_top_clk_data;
> > > -static struct clk_hw_onecell_data *mt8173_pll_clk_data;
> >
> > You wouldn't have to touch these lines twice?
> >
>
> That's true, but please, I prefer not to, as the patches are ordered for
> eas(y/ier) bisectability in case anything happens.

Got it.