Re: [PATCH v2 00/23] MediaTek clocks cleanups and improvements

Chen-Yu Tsai
2022-12-30T06:42:56Z

On Fri, Dec 30, 2022 at 2:13 PM Miles Chen <miles.chen@mediatek.com> wrote:
> > Changes in v2:
> > - Moved dt-bindings CLK_DUMMY to clk-mtk.h instead
> >
> >
> > This series performs cleanups and improvements on MediaTek clock
> > drivers, greatly reducing code duplication (hence also reducing
> > kernel size).
> >
> > There would be a lot to say about it, but summarizing:
> >
> > * Propagates struct device where possible in order to introduce the
> > possibility of using Runtime PM on clock drivers as needed,
> > possibly enhancing reliability of some platforms (obviously, this
> > will do nothing unless power-domains are added to devicetree);
> >
> > * Cleans up some duplicated clock(s) registration attempt(s): on
> > some platforms the 26M fixed factor clock is registered early,
> > but then upon platform_driver probe, an attempt to re-register
> > that clock was performed;
> >
> > * Removes some early clock registration where possible, moving
> > everything to platform_driver clock probe;
> >
> > * Breaks down the big MT8173 clock driver in multiple ones, as it's
> > already done with the others, cleans it up and adds possibility
> > possibility to compile non-boot-critical clock drivers (for 8173)
> > as modules;
> >
> > * Extends the common mtk_clk_simple_probe() function to be able to
> > register multiple MediaTek clock types;
> >
> > * Removes duplicated [...]_probe functions from multiple MediaTek SoC
> > clock drivers, migrating almost everything to the common functions
> > mtk_clk_simple_probe();
> >
> > * Adds a .remove() callback, pointing to the common mtk_clk_simple_remove()
> > function to all clock drivers that were migrated to the common probe;
> >
> > * Some more spare cleanups here and there.
> >
> > All of this was manually tested on various Chromebooks (with different MTK
> > SoCs) and no regression was detected.
> >
> > Cheers!
>
> I tested this v2 series on mt6779 and mt8192 without any problem.

Please give Tested-by. :)