From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A91F4C61DA4 for ; Mon, 6 Mar 2023 05:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229753AbjCFF03 (ORCPT ); Mon, 6 Mar 2023 00:26:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbjCFF0T (ORCPT ); Mon, 6 Mar 2023 00:26:19 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5DF91A67B for ; Sun, 5 Mar 2023 21:25:48 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ3Lo-0002Jh-Mp; Mon, 06 Mar 2023 06:25:32 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pZ3Ln-00021g-I6; Mon, 06 Mar 2023 06:25:31 +0100 Date: Mon, 6 Mar 2023 06:25:31 +0100 From: Oleksij Rempel To: Stefan Wahren Cc: Shawn Guo , Sascha Hauer , Abel Vesa , Fabio Estevam , NXP Linux Team , "linux-clk@vger.kernel.org" , Linux ARM , Michael Heimpold Subject: Re: imx6ul: Recent enet refclock changes breaks custom i.mx6ull board Message-ID: <20230306052531.GA30081@pengutronix.de> References: <3ceda169-de1b-2c1f-9ee8-bc8fdb547433@i2se.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3ceda169-de1b-2c1f-9ee8-bc8fdb547433@i2se.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hi Stefan, On Sun, Mar 05, 2023 at 11:16:17PM +0100, Stefan Wahren wrote: > Hi, > > we planned to submit our custom i.MX6ULL board [1] to mainline after release > of Linux 6.3-rc1, but the recent enet refclock changes breaks our Ethernet > phy: > > [    0.000000] imx:clk-gpr-mux: failed to get parent (-EINVAL) > > ... > > [   18.574595] SMSC LAN8710/LAN8720 2188000.ethernet-1:00: phy_poll_reset > failed: -110 > [   18.581064] fec 2188000.ethernet eth0: Unable to connect to phy > > I narrow down the PHY issue to this first bad commit: > > 5f82bfced611 ("clk: imx6ul: fix enet1 gate configuration") > > The clock issues seems to be cause by the following commit. If i revert > 5f82bfced611 and 4e197ee880c24 or use Linux 6.2 everything is fine. It looks like in your kernel version are some missing patches. Can you please rebase your patches on top of this branch: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=for-next and please rename IMX6UL_CLK_ENET_REF to IMX6UL_CLK_ENET1_REF_SEL in your dtsi. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |