Re: [PATCH v7 21/22] riscv: dts: starfive: Add StarFive JH7110 VisionFive 2 board device tree

Hal Feng
2023-04-05T01:40:39Z

On Wed, 5 Apr 2023 02:38:25 +0800, Shengyu Qu wrote:
> Hi Hal,
>
>> +    aliases {
>> +        i2c0 = &i2c0;
>> +        i2c2 = &i2c2;
>> +        i2c5 = &i2c5;
>> +        i2c6 = &i2c6;
>> +        serial0 = &uart0;
>> +    };
>> +
>> +    chosen {
>> +        stdout-path = "serial0:115200n8";
>> +    };
>> +
>> +    cpus {
>> +        timebase-frequency = <4000000>;
>
> Is mtime frequency on JH7110 could be modified?  If not, I think it's better
>
> to put it into jh7110.dtsi.

This frequency is from (osc / 6). This is based on the frequency
of the crystal oscillator on the board. So we set it here.

Best regards,
Hal

>
>> +    };
>> +
>> +    memory@40000000 {
>> +        device_type = "memory";
>> +        reg = <0x0 0x40000000 0x1 0x0>;
>> +    };
>> +
>> +    gpio-restart {
>> +        compatible = "gpio-restart";
>> +        gpios = <&sysgpio 35 GPIO_ACTIVE_HIGH>;
>> +        priority = <224>;
>> +    };
>> +};
>> +
>
> Best regards,
>
> Shengyu
>