Re: [PATCH v10 05/10] dt-bindings: arm: Add initial bindings for Nuvoton platform

Rob Herring
2023-05-08T03:26:45Z

On Mon, 08 May 2023 02:59:31 +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@nuvoton.com>
>
> Modify Nuvoton NPCM and MA35 platform board bindings
> - Move 'nuvoton,npcm-gcr.yaml' from 'bindings/arm/npcm' to
> 'bindings/soc/nuvoton'.
> - Rename the 'bindings/arm/npcm' directory to 'bindings/arm/nuvoton'.
> - Add bindings for ARMv8-based Nuvoton SoCs and platform boards, and
> include the initial bindings for ma35d1 series development boards.
>
> Modify MAINTAINERS
> - Remove the line for 'bindings/arm/npcm/' under ARM/NUVOTON NPCM, as it
> has been renamed.
> - Add ARM/NUVOTON MA35 for Nuvoton MA35 series SoCs maintainer and files.
>
> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../bindings/arm/nuvoton/nuvoton,ma35d1.yaml | 30 +++++++++++++++++++
> .../npcm.yaml => nuvoton/nuvoton,npcm.yaml} | 2 +-
> .../nuvoton/nuvoton,npcm-gcr.yaml} | 2 +-
> MAINTAINERS | 13 +++++++-
> 4 files changed, 44 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/arm/nuvoton/nuvoton,ma35d1.yaml
> rename Documentation/devicetree/bindings/arm/{npcm/npcm.yaml => nuvoton/nuvoton,npcm.yaml} (93%)
> rename Documentation/devicetree/bindings/{arm/npcm/nuvoton,gcr.yaml => soc/nuvoton/nuvoton,npcm-gcr.yaml} (93%)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml

doc reference errors (make refcheckdocs):
Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230508025936.36776-6-ychuang570808@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.