From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7443FC77B75 for ; Tue, 9 May 2023 05:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbjEIFuz (ORCPT ); Tue, 9 May 2023 01:50:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234624AbjEIFuy (ORCPT ); Tue, 9 May 2023 01:50:54 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 508AE903C for ; Mon, 8 May 2023 22:50:52 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-518d325b8a2so4970747a12.0 for ; Mon, 08 May 2023 22:50:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683611452; x=1686203452; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=AOxvOPHTRilyOmLohM9swFUYHYoS09dGPpcRJnsGSWU=; b=t6ApgQ/F7HvkVQL89vfe2rdqcHFhb1NwKfBKD7o4ppUVe+Qg0zQ73Te321bDYDY8iX 5g0CFvv0r92cnQ/vHF+NlR/ThcUK+B/4bdvUaaDm+0Y+H0SJLTmCgIZmCR/iw1mFNmXE R4edOBnq/iaZABkuU5oepOrICQvrCMtWZ/iABzHfGwtXNBOvP8fEA3sRtPgd5c3RRGWM 6vlAPmafDY0tM9eEote65wu6WQ17xJ11r1do93qSDS9+ZNXHjEU4vCfbZn6cLZrYYS/o XB4swlYNVBmdZ/4vuo+bLq5GlX5vQYu/B3HnnR6syW2KQysLNQjzMwDBuO1pMPjsKC0Z gE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683611452; x=1686203452; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AOxvOPHTRilyOmLohM9swFUYHYoS09dGPpcRJnsGSWU=; b=j+RVTqhZ2IbfWFqkrawpnaWOOA0Ei2grJFUVQw8AEx2P0OvoOw0EFwHkhV6i8T+EIg /lhi425/BNvUHfS0TOf/szJMc2tcV1xIaib8p4EU7FgWO98LHeOZRH9TUooypo4Y2GY4 0kONLIrmXf4QqAoJMsIj+u0G7nl3EMLUTnAnrtE9q88NjniiftG7Z+xW8I2hddI/WYZ6 aUDBpLMzhmOe8JRDnMLjNWpu+ZUDMvlX55IzGZ+rjAra/EgNc55otknLIim8rhgH9f/q DX8FA9x6JHncF7f60WGO4wHUjXC/+L00LCnnJFyaFMpbF4S10C9wxmJc8bDYo+NtoGeS yBew== X-Gm-Message-State: AC+VfDw4rH4VVtkRuDNvxxK6pO4HRXuaS1XKUfj/eFiWTL7B4shGXG9o HgQiXevR5yvPKzaT7c451BSP X-Google-Smtp-Source: ACHHUZ7sh9t6z0347Cym3km5R6SVH/r+Go7Ckx/CKViYyIgoDbGRY2pAY4lbQJgCW/QCr88TMVTu/Q== X-Received: by 2002:a17:902:d50d:b0:1ac:5382:6e24 with SMTP id b13-20020a170902d50d00b001ac53826e24mr11881045plg.10.1683611451718; Mon, 08 May 2023 22:50:51 -0700 (PDT) Received: from thinkpad ([59.92.97.45]) by smtp.gmail.com with ESMTPSA id i12-20020a17090332cc00b001ac5896e96esm523686plr.207.2023.05.08.22.50.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 22:50:50 -0700 (PDT) Date: Tue, 9 May 2023 11:20:44 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/2] clk: qcom: mmcc-msm8974: fix MDSS_GDSC power flags Message-ID: <20230509055044.GA4823@thinkpad> References: <20230507175335.2321503-1-dmitry.baryshkov@linaro.org> <20230507175335.2321503-2-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230507175335.2321503-2-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Sun, May 07, 2023 at 08:53:35PM +0300, Dmitry Baryshkov wrote: > Using PWRSTS_RET on msm8974's MDSS_GDSC causes display to stop working. > The gdsc doesn't fully come out of retention mode. Change it's pwrsts > flags to PWRSTS_OFF_ON. > What does "stop working" implies? Does it work during boot and randomly stopped working or it stopped working after resume from suspend? Even though reverting to non-retention mode works, I think the issue might be somewhere else. Like the vote might be missing to get the GDSC out of retention mode. - Mani > Fixes: d399723950c4 ("clk: qcom: gdsc: Fix the handling of PWRSTS_RET support") > Signed-off-by: Dmitry Baryshkov > --- > drivers/clk/qcom/mmcc-msm8974.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c > index aa29c79fcd55..277ef0065aae 100644 > --- a/drivers/clk/qcom/mmcc-msm8974.c > +++ b/drivers/clk/qcom/mmcc-msm8974.c > @@ -2401,7 +2401,7 @@ static struct gdsc mdss_gdsc = { > .pd = { > .name = "mdss", > }, > - .pwrsts = PWRSTS_RET_ON, > + .pwrsts = PWRSTS_OFF_ON, > }; > > static struct gdsc camss_jpeg_gdsc = { > -- > 2.39.2 > -- மணிவண்ணன் சதாசிவம்