From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5067CC77B7D for ; Wed, 10 May 2023 09:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236258AbjEJJOB (ORCPT ); Wed, 10 May 2023 05:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231486AbjEJJOA (ORCPT ); Wed, 10 May 2023 05:14:00 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3772D30CF; Wed, 10 May 2023 02:13:59 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 88CB45C02DD; Wed, 10 May 2023 05:13:56 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 10 May 2023 05:13:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683710036; x=1683796436; bh=ii ADo2HcVVP7FI0vsjXgBbOVG3uyaHWjU7aM/iZfF6g=; b=fQ0pc45lup697IbFq5 7VfBPUM54DU4ba+Je2Aw+5Rl872ZxULr52/WGOoXdFFpAl8AZXFGoH38GIf7UnN1 BxUKsq+wYdfRRLiNjpkpcPnWiMXgP4+F52tztVHZalAlnnWLQq61doK+VRkDZ58a q+k8ePiWGuKJz59iCuZm6VOz10qggDNyYwM5r86dsRfMgsHoB76MdyiedlCX3ePm HET49vPIajwacbIxAd8puh6GNMimHkCoMavggq02i8PhM1pNtHMFYa18JpXwMP3K PO/GlhCRyfWQ6a5gU8TjzqafJH2tp0/Yt2Awc83wL9auOBgpvy3ixvCVdFbdIAwQ JJfw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683710036; x=1683796436; bh=iiADo2HcVVP7F I0vsjXgBbOVG3uyaHWjU7aM/iZfF6g=; b=P7rchaHWU3Ofd9cQJ+ipo5Su4l+CW l2GrrIG3tC11y4REJsbZEDvHafr6jSH/OpUW6rcB3TpKbRORc4Wcvg7WkSVFRJIr ctq4UH4neT2ulzTHFIomba4ThhMVVjjpZ1Ah5QhR72YfIixWffPWWmU0M6gVlBtS qItRsQFQctqMuNdeIvkGnlzJkf8C36JtwlDzUFG694bBMWB+kJ7AX/hoJo5lRvxX eSJpnrpLcP4s8hgqETMAvMEmzquITy+cJ1WCjC83dBgKv8IBWK65HsYuctgDujtc R+2CTMi9gwSwEIGCWWAMkbOleBNRYq56KGVWl51esed5I6CGFenUaOQbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeghedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepgeehue ehgfdtledutdelkeefgeejteegieekheefudeiffdvudeffeelvedttddvnecuffhomhgr ihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Feedback-ID: i787e41f1:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 05:13:55 -0400 (EDT) Date: Wed, 10 May 2023 11:13:51 +0200 From: Greg KH To: Peng Fan Cc: "Peng Fan (OSS)" , "abelvesa@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , dl-linux-imx , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] clk: imx: imx93: introduce clk_bypassed module parameter Message-ID: <2023051027-wages-feminine-cb5d@gregkh> References: <20230504085506.504474-1-peng.fan@oss.nxp.com> <2023050410-rejoin-vocation-8560@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, May 10, 2023 at 07:49:20AM +0000, Peng Fan wrote: > > > Subject: Re: [PATCH] clk: imx: imx93: introduce clk_bypassed module > > parameter > > > > On Thu, May 04, 2023 at 04:55:06PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > With the clk names specified in clk_bypassed module parameter, give > > > user an option to bypass the clk from managing them by Linux kernel. > > > > As I said on another email, no, please do not add new module parameters > > for drivers, this is not the 1990s > > After a search of the list, > https://lore.kernel.org/all/?q=module_param > > I still see many drivers are adding module_param. And they should not be doing so as it is almost always not a good idea (note, some subsystems, like sound, do require it, as that's the api they use, so this is not a blanket statement.) > Is this is strict ban that new platform driver should not add > module_param? You need to really really really justify, and document in the changelog text, why all of the other methods of configuring a platform driver will not work in order to have it considered. thanks, greg k-h