From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5688C77B7F for ; Thu, 11 May 2023 15:26:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238654AbjEKP06 (ORCPT ); Thu, 11 May 2023 11:26:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238569AbjEKP05 (ORCPT ); Thu, 11 May 2023 11:26:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA531DC for ; Thu, 11 May 2023 08:26:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41D7164EFD for ; Thu, 11 May 2023 15:26:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25F4EC433D2; Thu, 11 May 2023 15:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683818815; bh=+7QZL904BwNTluSbT6if/okhWOSRPnmftg11VAD2xDo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AwJPvKdeQ/qOhlz8YnKglbSmyFnTBjI7CB5q7FzWN+mvNRm4N3P30F2UfnADhhJRS iwOUcLAR3LNlFH5U0IAz2G/pMcS5fk1Sgmmv53176KUpUpqN/7Wwt121Hfw/of3e8Q W8CK04fSZUAQWJsljL/ADCV+IevNDFV/5XJXZygQgSFL3INYYodZyoEVNdi5hEsQwO lbiEQXv6xevyJvoXuCbogi6eToMRUcM+1sF6UdgcG+UAUp9IZrrdKLWcAGTXAtCcDJ 2uUS+Go9tvDCzk3RFhldV/FjFNsr/9FC9EJ75CNQFExOt7NqnQ2U8be84ztcNRSsUI y4BOWzybO+Cjg== Date: Thu, 11 May 2023 08:26:54 -0700 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Jiri Pirko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Vadim Fedorenko Subject: Re: [RFC PATCH v7 1/8] dpll: spec: Add Netlink spec in YAML Message-ID: <20230511082654.44883ebe@kernel.org> In-Reply-To: References: <20230428002009.2948020-1-vadfed@meta.com> <20230428002009.2948020-2-vadfed@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, 11 May 2023 07:38:04 +0000 Kubalewski, Arkadiusz wrote: > >>+ - > >>+ type: enum > >>+ name: event > >>+ doc: events of dpll generic netlink family > >>+ entries: > >>+ - > >>+ name: unspec > >>+ doc: invalid event type > >>+ - > >>+ name: device-create > >>+ doc: dpll device created > >>+ - > >>+ name: device-delete > >>+ doc: dpll device deleted > >>+ - > >>+ name: device-change > > > >Please have a separate create/delete/change values for pins. > > > > Makes sense, but details, pin creation doesn't occur from uAPI perspective, > as the pins itself are not visible to the user. They are visible after they > are registered with a device, thus we would have to do something like: > - pin-register > - pin-unregister > - pin-change > > Does it make sense? I missed this, notifications should be declared under operations. Please look at netdev.yaml for an example. I thought about implementing this model where events are separate explicitly but I think it's an unnecessary complication.