From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DD82EB64D7 for ; Mon, 26 Jun 2023 09:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbjFZJhG (ORCPT ); Mon, 26 Jun 2023 05:37:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjFZJhF (ORCPT ); Mon, 26 Jun 2023 05:37:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 311ECAC for ; Mon, 26 Jun 2023 02:37:03 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDieT-0003on-U0; Mon, 26 Jun 2023 11:36:53 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qDieS-0003FA-RV; Mon, 26 Jun 2023 11:36:52 +0200 Date: Mon, 26 Jun 2023 11:36:52 +0200 From: Sascha Hauer To: Alibek Omarov Cc: linux-rockchip@lists.infradead.org, Michael Turquette , Stephen Boyd , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: rockchip: rk3568: Fix PLL rate setting for 78.75MHz Message-ID: <20230626093652.GR18491@pengutronix.de> References: <20230614134750.1056293-1-a1ba.omarov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230614134750.1056293-1-a1ba.omarov@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-clk@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, Jun 14, 2023 at 04:47:50PM +0300, Alibek Omarov wrote: > PLL rate on RK356x is calculated through the simple formula: > ((24000000 / _refdiv) * _fbdiv) / (_postdiv1 * _postdiv2) > > The PLL rate setting for 78.75MHz seems to be copied from 96MHz > so this patch fixes it and configures it properly. > > Signed-off-by: Alibek Omarov > Fixes: 842f4cb72639 ("clk: rockchip: Add more PLL rates for rk3568") Reviewed-by: Sascha Hauer > --- > drivers/clk/rockchip/clk-rk3568.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c > index 5dae960af4ce..48b8d06c305c 100644 > --- a/drivers/clk/rockchip/clk-rk3568.c > +++ b/drivers/clk/rockchip/clk-rk3568.c > @@ -82,7 +82,7 @@ static struct rockchip_pll_rate_table rk3568_pll_rates[] = { > RK3036_PLL_RATE(101000000, 1, 101, 6, 4, 1, 0), > RK3036_PLL_RATE(100000000, 1, 150, 6, 6, 1, 0), > RK3036_PLL_RATE(96000000, 1, 96, 6, 4, 1, 0), > - RK3036_PLL_RATE(78750000, 1, 96, 6, 4, 1, 0), > + RK3036_PLL_RATE(78750000, 4, 315, 6, 4, 1, 0), refdiv = 4 fbdiv = 315 postdiv1 = 6 postdiv2 = 4 ((24000000 / 4) * 315) / 6 / 4 = 78750000 LGTM Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |