From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5E7CC0015E for ; Fri, 21 Jul 2023 08:28:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229554AbjGUI2M (ORCPT ); Fri, 21 Jul 2023 04:28:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbjGUI2L (ORCPT ); Fri, 21 Jul 2023 04:28:11 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BADAF271F; Fri, 21 Jul 2023 01:28:06 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 14019C000B; Fri, 21 Jul 2023 08:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689928085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6oK8s2+9bUabRHihoIYVqFABjBAIRG/KLAax2RRr0NI=; b=ZZkWysdJVJ17zwfnwJ57XB20BrEBMG78ozub8Ea5dL3qWVve+zdtr4+0dOqkspZr0QM1F3 WzUFt1cHGdBl6T6cbELu1H7+nQJk1sYjzKXETztEHDdF0yzPEH5chftbGkf4tVbXoaOhSb V4mqB84YFgluRoYZEZlqbKcellemdZVq/gqafvK5AXZqeDh8pUjg30hC/d5LM8Uu0ekPGu BX3LF5INv1l92lJkLC34i6nmERwaPx7eUYsbpobshi3w0r8t5wgWVyBv+vyvSdS3JcxlUN USBqh1mldsQnQtAvtrZYYqMmT5elz7134K17ukmqA55jK+S8JAiPibp4c3UJZw== Date: Fri, 21 Jul 2023 10:28:02 +0200 From: Luca Ceresoli To: Biju Das Cc: Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Geert Uytterhoeven , Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org, Marek Vasut Subject: Re: [PATCH v2 1/2] clk: vc5: Use i2c_get_match_data() instead of device_get_match_data() Message-ID: <20230721102802.41eeaf12@booty> In-Reply-To: <20230721070019.96627-2-biju.das.jz@bp.renesas.com> References: <20230721070019.96627-1-biju.das.jz@bp.renesas.com> <20230721070019.96627-2-biju.das.jz@bp.renesas.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Hello Biju, On Fri, 21 Jul 2023 08:00:18 +0100 Biju Das wrote: > The device_get_match_data(), is to get match data for firmware interfaces > such as just OF/ACPI. This driver has I2C matching table as well. Use > i2c_get_match_data() to get match data for I2C, ACPI and DT-based > matching. > > Signed-off-by: Biju Das > Reviewed-by: Marek Vasut > Reviewed-by: Geert Uytterhoeven > --- > v1->v2: > * Added Rb tags from Geert and Marek. > * Removed error check as all tables have data pointers. > * Retained Rb tag as the change is trivial. Reviewed-by: Luca Ceresoli -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com