From: Alex Bee <knaerzche@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Lee Jones <lee@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: Elaine Zhang <zhangqing@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org,
linux-clk@vger.kernel.org, linux-phy@lists.infradead.org,
Finley Xiao <finley.xiao@rock-chips.com>,
Alex Bee <knaerzche@gmail.com>
Subject: [PATCH 05/31] clk: rockchip: rk3128: Fix aclk_peri_src parent
Date: Tue, 29 Aug 2023 19:16:21 +0200 [thread overview]
Message-ID: <20230829171647.187787-6-knaerzche@gmail.com> (raw)
In-Reply-To: <20230829171647.187787-1-knaerzche@gmail.com>
From: Finley Xiao <finley.xiao@rock-chips.com>
According to the TRM there are no specific cpll_peri, gpll_div2_peri or
gpll_div3_peri gates, but a single clk_peri_src gate and the peri mux
directly connects to the plls respectivly the pll divider clocks.
Fix this by creating a single gated composite.
Also rename all occurrences of "aclk_peri_src*" to clk_peri_src, since it
is the parent for both peri aclks and hclks and that also matches the
naming in the TRM.
Fixes: f6022e88faca ("clk: rockchip: add clock controller for rk3128")
Signed-off-by: Finley Xiao <finley.xiao@rock-chips.com>
[renamed aclk_peri_src -> clk_peri_src and added commit message]
Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
drivers/clk/rockchip/clk-rk3128.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/clk/rockchip/clk-rk3128.c b/drivers/clk/rockchip/clk-rk3128.c
index aa53797dbfc1..fcacfe758829 100644
--- a/drivers/clk/rockchip/clk-rk3128.c
+++ b/drivers/clk/rockchip/clk-rk3128.c
@@ -138,7 +138,7 @@ PNAME(mux_pll_src_5plls_p) = { "cpll", "gpll", "gpll_div2", "gpll_div3", "usb480
PNAME(mux_pll_src_4plls_p) = { "cpll", "gpll", "gpll_div2", "usb480m" };
PNAME(mux_pll_src_3plls_p) = { "cpll", "gpll", "gpll_div2" };
-PNAME(mux_aclk_peri_src_p) = { "gpll_peri", "cpll_peri", "gpll_div2_peri", "gpll_div3_peri" };
+PNAME(mux_clk_peri_src_p) = { "gpll", "cpll", "gpll_div2", "gpll_div3" };
PNAME(mux_mmc_src_p) = { "cpll", "gpll", "gpll_div2", "xin24m" };
PNAME(mux_clk_cif_out_src_p) = { "clk_cif_src", "xin24m" };
PNAME(mux_sclk_vop_src_p) = { "cpll", "gpll", "gpll_div2", "gpll_div3" };
@@ -275,23 +275,17 @@ static struct rockchip_clk_branch common_clk_branches[] __initdata = {
RK2928_CLKGATE_CON(0), 11, GFLAGS),
/* PD_PERI */
- GATE(0, "gpll_peri", "gpll", CLK_IGNORE_UNUSED,
+ COMPOSITE(0, "clk_peri_src", mux_clk_peri_src_p, 0,
+ RK2928_CLKSEL_CON(10), 14, 2, MFLAGS, 0, 5, DFLAGS,
RK2928_CLKGATE_CON(2), 0, GFLAGS),
- GATE(0, "cpll_peri", "cpll", CLK_IGNORE_UNUSED,
- RK2928_CLKGATE_CON(2), 0, GFLAGS),
- GATE(0, "gpll_div2_peri", "gpll_div2", CLK_IGNORE_UNUSED,
- RK2928_CLKGATE_CON(2), 0, GFLAGS),
- GATE(0, "gpll_div3_peri", "gpll_div3", CLK_IGNORE_UNUSED,
- RK2928_CLKGATE_CON(2), 0, GFLAGS),
- COMPOSITE_NOGATE(0, "aclk_peri_src", mux_aclk_peri_src_p, 0,
- RK2928_CLKSEL_CON(10), 14, 2, MFLAGS, 0, 5, DFLAGS),
- COMPOSITE_NOMUX(PCLK_PERI, "pclk_peri", "aclk_peri_src", 0,
+
+ COMPOSITE_NOMUX(PCLK_PERI, "pclk_peri", "clk_peri_src", 0,
RK2928_CLKSEL_CON(10), 12, 2, DFLAGS | CLK_DIVIDER_POWER_OF_TWO,
RK2928_CLKGATE_CON(2), 3, GFLAGS),
- COMPOSITE_NOMUX(HCLK_PERI, "hclk_peri", "aclk_peri_src", 0,
+ COMPOSITE_NOMUX(HCLK_PERI, "hclk_peri", "clk_peri_src", 0,
RK2928_CLKSEL_CON(10), 8, 2, DFLAGS | CLK_DIVIDER_POWER_OF_TWO,
RK2928_CLKGATE_CON(2), 2, GFLAGS),
- GATE(ACLK_PERI, "aclk_peri", "aclk_peri_src", 0,
+ GATE(ACLK_PERI, "aclk_peri", "clk_peri_src", 0,
RK2928_CLKGATE_CON(2), 1, GFLAGS),
GATE(SCLK_TIMER0, "sclk_timer0", "xin24m", 0,
--
2.42.0
next prev parent reply other threads:[~2023-08-29 17:19 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 17:16 [PATCH 00/31] Fix and improve Rockchip RK3128 support Alex Bee
2023-08-29 17:16 ` [PATCH 01/31] dt-bindings: mfd: syscon: Add rockchip,rk3128-qos compatible Alex Bee
2023-08-29 17:20 ` Krzysztof Kozlowski
2023-09-20 9:36 ` (subset) " Lee Jones
2023-08-29 17:16 ` [PATCH 02/31] dt-bindings: gpu: mali-utgard: Add Rockchip RK3128 compatible Alex Bee
2023-08-29 17:20 ` Krzysztof Kozlowski
2023-08-29 17:16 ` [PATCH 03/31] dt-bindings: ASoC: rockchip: Add compatible for RK3128 spdif Alex Bee
2023-08-29 17:21 ` Krzysztof Kozlowski
2023-08-29 17:16 ` [PATCH 04/31] dt-bindings: arm: rockchip: Add Geniatech XPI-3128 Alex Bee
2023-08-29 17:22 ` Krzysztof Kozlowski
2023-08-29 17:16 ` Alex Bee [this message]
2023-08-29 17:40 ` [PATCH 05/31] clk: rockchip: rk3128: Fix aclk_peri_src parent Krzysztof Kozlowski
2023-08-29 18:36 ` Alex Bee
2023-08-29 17:16 ` [PATCH 06/31] clk: rockchip: rk3128: Fix hclk_otg gate Alex Bee
2023-08-29 17:16 ` [PATCH 07/31] clk: rockchip: rk3128: Fix SCLK_SDMMC's clock name Alex Bee
2023-08-29 17:16 ` [PATCH 08/31] phy: rockchip-inno-usb2: Split ID interrupt phy registers Alex Bee
2023-09-21 13:43 ` Vinod Koul
2023-08-29 17:16 ` [PATCH 09/31] phy: phy-rockchip-inno-usb2: Add RK3128 support Alex Bee
2023-08-29 17:16 ` [PATCH 10/31] ARM: dts: rockchip: Fix i2c0 register address for RK3128 Alex Bee
2023-08-29 17:16 ` [PATCH 11/31] ARM: dts: rockchip: Add missing arm timer interrupt " Alex Bee
2023-08-29 17:16 ` [PATCH 12/31] ARM: dts: rockchip: Add missing quirk for RK3128's dma engine Alex Bee
2023-08-29 17:16 ` [PATCH 13/31] ARM: dts: rockchip: Fix timer clocks for RK3128 Alex Bee
2023-08-29 17:16 ` [PATCH 14/31] ARM: dts: rockchip: Disable non-required timers " Alex Bee
2023-08-29 17:16 ` [PATCH 15/31] ARM: dts: rockchip: Split RK3128 devictree for RK312x SoC family Alex Bee
2023-08-29 17:24 ` Krzysztof Kozlowski
2023-08-29 17:16 ` [PATCH 16/31] ARM: dts: rockchip: Add SRAM node for RK312x Alex Bee
2023-08-29 17:25 ` Krzysztof Kozlowski
2023-08-29 17:16 ` [PATCH 17/31] ARM: dts: rockchip: Add CPU resets " Alex Bee
2023-08-29 17:25 ` Krzysztof Kozlowski
2023-08-29 17:16 ` [PATCH 18/31] ARM: dts: rockchip: Enable SMP bringup " Alex Bee
2023-08-29 17:16 ` [PATCH 19/31] ARM: dts: rockchip: Switch to operating-points-v2 for RK312x's CPU Alex Bee
2023-08-29 17:16 ` [PATCH 20/31] ARM: dts: rockchip: Add extra CPU voltages for RK3126 Alex Bee
2023-08-29 17:16 ` [PATCH 21/31] ARM: dts: rockchip: add power controller for RK312x Alex Bee
2023-08-29 17:16 ` [PATCH 22/31] ARM: dts: rockchip: Add GPU node " Alex Bee
2023-08-29 17:16 ` [PATCH 23/31] ARM: dts: rockchip: Add 2-channel I2S " Alex Bee
2023-08-29 17:16 ` [PATCH 24/31] ARM: dts: rockchip: Add 8-channel I2S for RK3128 Alex Bee
2023-08-29 17:16 ` [PATCH 25/31] ARM: dts: rockchip: Add spdif " Alex Bee
2023-08-29 17:16 ` [PATCH 26/31] ARM: dts: rockchip: Add gmac " Alex Bee
2023-08-29 17:16 ` [PATCH 27/31] ARM: dts: rockchip: Add dwc2 otg fifo siztes for RK312x Alex Bee
2023-08-29 17:16 ` [PATCH 28/31] ARM: dts: rockchip: Add USB host clocks " Alex Bee
2023-08-29 17:16 ` [PATCH 29/31] ARM: dts: rockchip: Make usbphy the parent of SCLK_USB480M " Alex Bee
2023-08-29 17:16 ` [PATCH 30/31] ARM: dts: rockchip: Add sdmmc_det pinctrl " Alex Bee
2023-08-29 17:16 ` [PATCH 31/31] ARM: dts: Add Geniatech XPI-3128 RK3128 board Alex Bee
2023-09-26 8:08 ` (subset) [PATCH 00/31] Fix and improve Rockchip RK3128 support Mark Brown
2023-11-27 13:22 ` Vinod Koul
2023-12-12 20:03 ` Heiko Stuebner
2023-12-13 20:29 ` Alex Bee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230829171647.187787-6-knaerzche@gmail.com \
--to=knaerzche@gmail.com \
--cc=airlied@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vkoul@kernel.org \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox