Re: [PATCH v3 1/5] dt-bindings: mfd: convert twl-family.txt to json-schema

Conor Dooley
2023-09-12T17:00:28Z

[-- Attachment #1: Type: text/plain, Size: 5372 bytes --]

On Tue, Sep 12, 2023 at 12:13:42AM +0200, Andreas Kemnade wrote:
> Convert the TWL[46]030 binding to DT schema format. To do it as a step by
> step work, do not include / handle nodes for subdevices yet, just convert
> things with minimal corrections. There are already some bindings for its
> subdevices in the tree.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> .../bindings/input/twl4030-pwrbutton.txt | 2 +-
> .../devicetree/bindings/mfd/ti,twl.yaml | 64 +++++++++++++++++++
> .../devicetree/bindings/mfd/twl-family.txt | 46 -------------
> 3 files changed, 65 insertions(+), 47 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,twl.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/twl-family.txt
>
> diff --git a/Documentation/devicetree/bindings/input/twl4030-pwrbutton.txt b/Documentation/devicetree/bindings/input/twl4030-pwrbutton.txt
> index f5021214edecb..6c201a2ba8acf 100644
> --- a/Documentation/devicetree/bindings/input/twl4030-pwrbutton.txt
> +++ b/Documentation/devicetree/bindings/input/twl4030-pwrbutton.txt
> @@ -1,7 +1,7 @@
> Texas Instruments TWL family (twl4030) pwrbutton module
>
> This module is part of the TWL4030. For more details about the whole
> -chip see Documentation/devicetree/bindings/mfd/twl-family.txt.
> +chip see Documentation/devicetree/bindings/mfd/ti,twl.yaml.
>
> This module provides a simple power button event via an Interrupt.
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> new file mode 100644
> index 0000000000000..f125b254a4b93
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,twl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TWL family
> +
> +maintainers:
> + - Andreas Kemnade <andreas@kemnade.info>
> +
> +description: |

FWIW the | is not needed here, but that's w/e.

This seems fine to me though,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> + The TWLs are Integrated Power Management Chips.
> + Some version might contain much more analog function like
> + USB transceiver or Audio amplifier.
> + These chips are connected to an i2c bus.
> +
> +properties:
> + compatible:
> + description:
> + TWL4030 for integrated power-management/audio CODEC device used in OMAP3
> + based boards
> + TWL6030/32 for integrated power-management used in OMAP4 based boards
> + enum:
> + - ti,twl4030
> + - ti,twl6030
> + - ti,twl6032
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic@48 {
> + compatible = "ti,twl6030";
> + reg = <0x48>;
> + interrupts = <39>; /* IRQ_SYS_1N cascaded to gic */
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + interrupt-parent = <&gic>;
> + };
> + };
> +
> diff --git a/Documentation/devicetree/bindings/mfd/twl-family.txt b/Documentation/devicetree/bindings/mfd/twl-family.txt
> deleted file mode 100644
> index c2f9302965dea..0000000000000
> --- a/Documentation/devicetree/bindings/mfd/twl-family.txt
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -Texas Instruments TWL family
> -
> -The TWLs are Integrated Power Management Chips.
> -Some version might contain much more analog function like
> -USB transceiver or Audio amplifier.
> -These chips are connected to an i2c bus.
> -
> -
> -Required properties:
> -- compatible : Must be "ti,twl4030";
> - For Integrated power-management/audio CODEC device used in OMAP3
> - based boards
> -- compatible : Must be "ti,twl6030";
> - For Integrated power-management used in OMAP4 based boards
> -- interrupts : This i2c device has an IRQ line connected to the main SoC
> -- interrupt-controller : Since the twl support several interrupts internally,
> - it is considered as an interrupt controller cascaded to the SoC one.
> -- #interrupt-cells = <1>;
> -
> -Optional node:
> -- Child nodes contain in the twl. The twl family is made of several variants
> - that support a different number of features.
> - The children nodes will thus depend of the capability of the variant.
> -
> -
> -Example:
> -/*
> - * Integrated Power Management Chip
> - * https://www.ti.com/lit/ds/symlink/twl6030.pdf
> - */
> -twl@48 {
> - compatible = "ti,twl6030";
> - reg = <0x48>;
> - interrupts = <39>; /* IRQ_SYS_1N cascaded to gic */
> - interrupt-controller;
> - #interrupt-cells = <1>;
> - interrupt-parent = <&gic>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - twl_rtc {
> - compatible = "ti,twl_rtc";
> - interrupts = <11>;
> - reg = <0>;
> - };
> -};
> --
> 2.39.2
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]